Show special string in SignInPreference summary when signin is disabled

Show special string in SignInPreference summary when signin is disabled

When signin is disabled by policy, Chrome Settings on Android show disabled
"Sign in to Chrome" preference row anyway. This CL adds
"Disabled by the administrator of this device" string to show in the preference
summary in such a case.

BUG=709574
Review-Url: https://codereview.chromium.org/2856173002
Cr-Commit-Position: refs/heads/master@{#469420}
Committed: https://chromium.googlesource.com/chromium/src/+/8b9dc9a3f71758c76310657d1b9dd235dee24913

[bsazonov, 2017-05-03 15:07:09]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 15:07:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 15:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 15:50:15]

Dry run: This issue passed the CQ dry run.

[bsazonov, 2017-05-03 19:16:51]

bsazonov@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[bsazonov, 2017-05-03 19:16:52]

Dan, please take a look.

[gone, 2017-05-03 20:41:52]

lgtm % asking Shimi about a description string to use for the translators.

https://codereview.chromium.org/2856173002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2856173002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:273: <message
name="IDS_SIGN_IN_TO_CHROME_DISABLED_SUMMARY" desc="Summary for disabled button
to sign in to Chrome when signin is disabled by the device administrator.">
I think you need to ask Shimi about the description string, too.

[srahim, 2017-05-04 17:58:12]

On 2017/05/03 20:41:52, slow (dfalcantara) wrote:
> lgtm % asking Shimi about a description string to use for the translators.
> 
>
https://codereview.chromium.org/2856173002/diff/1/chrome/android/java/strings...
> File chrome/android/java/strings/android_chrome_strings.grd (right):
> 
>
https://codereview.chromium.org/2856173002/diff/1/chrome/android/java/strings...
> chrome/android/java/strings/android_chrome_strings.grd:273: <message
> name="IDS_SIGN_IN_TO_CHROME_DISABLED_SUMMARY" desc="Summary for disabled
button
> to sign in to Chrome when signin is disabled by the device administrator.">
> I think you need to ask Shimi about the description string, too.

Good catch, here is the suggested description:
desc=“A descriptive line of text that appears under the 'Sign in to Chrome'
option, in Chrome Settings on Android. The text explains why 'Sign in to Chrome'
is disabled. 'Administrator' refers to the IT administrator of the
company/organization that owns the user’s device.” 














































































































































































































































































































































































































 option, in Chrome Settings on Android. The text appears to inform the user why
“Sign in” is disabled. “Administrator” refers to the IT administrator of the
company/organization that owns the user’s device.”

[bsazonov, 2017-05-04 18:41:06]

On 2017/05/04 17:58:12, srahim wrote:
> On 2017/05/03 20:41:52, slow (dfalcantara) wrote:
> > lgtm % asking Shimi about a description string to use for the translators.
> > 
> >
>
https://codereview.chromium.org/2856173002/diff/1/chrome/android/java/strings...
> > File chrome/android/java/strings/android_chrome_strings.grd (right):
> > 
> >
>
https://codereview.chromium.org/2856173002/diff/1/chrome/android/java/strings...
> > chrome/android/java/strings/android_chrome_strings.grd:273: <message
> > name="IDS_SIGN_IN_TO_CHROME_DISABLED_SUMMARY" desc="Summary for disabled
> button
> > to sign in to Chrome when signin is disabled by the device administrator.">
> > I think you need to ask Shimi about the description string, too.
> 
> Good catch, here is the suggested description:
> desc=“A descriptive line of text that appears under the 'Sign in to Chrome'
> option, in Chrome Settings on Android. The text explains why 'Sign in to
Chrome'
> is disabled. 'Administrator' refers to the IT administrator of the
> company/organization that owns the user’s device.” 

Wow, that is a very elaborate description (7th by length in all Chrome Android
string descriptions). Thanks a lot, Shimi!

[bsazonov, 2017-05-04 18:41:33]

The CQ bit was checked by bsazonov@chromium.org

[bsazonov, 2017-05-04 18:41:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2856173002/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-05-04 18:42:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 19:22:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493923293608170,
"parent_rev": "6c9c9ed06b946f1e9666212df891ffe8fc873077", "commit_rev":
"8b9dc9a3f71758c76310657d1b9dd235dee24913"}

[commit-bot: I haz the power, 2017-05-04 19:22:57]

Description was changed from

==========
Show special string in SignInPreference summary when signin is disabled

When signin is disabled by policy, Chrome Settings on Android show disabled
"Sign in to Chrome" preference row anyway. This CL adds
"Disabled by the administrator of this device" string to show in the preference
summary in such a case.

BUG=709574
==========

to

==========
Show special string in SignInPreference summary when signin is disabled

When signin is disabled by policy, Chrome Settings on Android show disabled
"Sign in to Chrome" preference row anyway. This CL adds
"Disabled by the administrator of this device" string to show in the preference
summary in such a case.

BUG=709574

Review-Url: https://codereview.chromium.org/2856173002
Cr-Commit-Position: refs/heads/master@{#469420}
Committed:
https://chromium.googlesource.com/chromium/src/+/8b9dc9a3f71758c76310657d1b9d...
==========

[commit-bot: I haz the power, 2017-05-04 19:23:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8b9dc9a3f71758c76310657d1b9d...