Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2856143002: Add month and year to time_format. (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Add month and year to time_format. Add the possibility to have month and years in time format. A year is defined as 365 days. A month is defined as 1year / 12. '1 month' means more than one month and less than two month (same for years). CL mainly made by olivierrobin BUG=694451 Review-Url: https://codereview.chromium.org/2845693002 Cr-Commit-Position: refs/heads/master@{#467625} (cherry picked from commit bef90b8dea482e8a4801f9c9c0543ab35ef2fd9f) Review-Url: https://codereview.chromium.org/2856143002 . Cr-Commit-Position: refs/branch-heads/3071@{#371} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/050c89a59b81cfd885b3f13054033a39b8cb0428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -91 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/l10n/formatter.h View 3 chunks +8 lines, -2 lines 0 comments Download
M ui/base/l10n/formatter.cc View 6 chunks +39 lines, -27 lines 0 comments Download
M ui/base/l10n/time_format.h View 3 chunks +29 lines, -7 lines 0 comments Download
M ui/base/l10n/time_format.cc View 4 chunks +34 lines, -2 lines 0 comments Download
M ui/base/l10n/time_format_unittest.cc View 8 chunks +139 lines, -51 lines 0 comments Download
M ui/strings/ui_strings.grd View 3 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
gambard
3 years, 7 months ago (2017-05-03 10:20:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
050c89a59b81cfd885b3f13054033a39b8cb0428.

Powered by Google App Engine
This is Rietveld 408576698