Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2845693002: Add month and year to time_format. (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, srahim+watch_chromium.org, jshin+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add month and year to time_format. Add the possibility to have month and years in time format. A year is defined as 365 days. A month is defined as 1year / 12. '1 month' means more than one month and less than two month (same for years). CL mainly made by olivierrobin BUG=694451 Review-Url: https://codereview.chromium.org/2845693002 Cr-Commit-Position: refs/heads/master@{#467625} Committed: https://chromium.googlesource.com/chromium/src/+/bef90b8dea482e8a4801f9c9c0543ab35ef2fd9f

Patch Set 1 #

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -91 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/l10n/formatter.h View 3 chunks +8 lines, -2 lines 0 comments Download
M ui/base/l10n/formatter.cc View 6 chunks +39 lines, -27 lines 0 comments Download
M ui/base/l10n/time_format.h View 1 3 chunks +29 lines, -7 lines 0 comments Download
M ui/base/l10n/time_format.cc View 4 chunks +34 lines, -2 lines 0 comments Download
M ui/base/l10n/time_format_unittest.cc View 8 chunks +139 lines, -51 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 3 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
gambard
PTAL. This is a new upload of https://codereview.chromium.org/2803593002/ with the comments answered in patchset 2.
3 years, 7 months ago (2017-04-26 18:28:54 UTC) #2
jungshik at Google
On 2017/04/26 18:28:54, gambard wrote: > PTAL. This is a new upload of https://codereview.chromium.org/2803593002/ with ...
3 years, 7 months ago (2017-04-26 20:26:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845693002/20001
3 years, 7 months ago (2017-04-27 08:21:10 UTC) #5
gambard
I am not sure about ICU, this will be cherry-picked in M59
3 years, 7 months ago (2017-04-27 08:22:16 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 09:23:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bef90b8dea482e8a4801f9c9c054...

Powered by Google App Engine
This is Rietveld 408576698