Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2856093004: Generalize content::URLDataSource so that it can be used by the network service. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
Reviewers:
yzshen1, Dan Beam
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, donnd+watch_chromium.org, jam, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, darin-cc_chromium.org, kmadhusu+watch_chromium.org, Jered, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generalize content::URLDataSource so that it can be used by the network service. -remove WillServiceRequest which wasn't used -change ShouldServiceRequest to take in the required fields, which are url, context and process ID BUG=717714 Review-Url: https://codereview.chromium.org/2856093004 Cr-Commit-Position: refs/heads/master@{#469160} Committed: https://chromium.googlesource.com/chromium/src/+/cf6f762f05c3d4aab0e127e556ab7852273d9807

Patch Set 1 #

Total comments: 4

Patch Set 2 : review comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -147 lines) Patch
M chrome/browser/search/iframe_source.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/search/iframe_source.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/search/iframe_source_unittest.cc View 1 3 chunks +16 lines, -30 lines 0 comments Download
M chrome/browser/search/instant_io_context.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/search/instant_io_context.cc View 3 chunks +9 lines, -21 lines 0 comments Download
M chrome/browser/search/local_ntp_source.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/browser/search/thumbnail_source.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/search/thumbnail_source.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_list_source.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/thumbnails/thumbnail_list_source.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/fallback_icon_source.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/fallback_icon_source.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/large_icon_source.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/large_icon_source.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/theme_source.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M components/dom_distiller/content/browser/dom_distiller_viewer_source.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/dom_distiller/content/browser/dom_distiller_viewer_source.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 2 chunks +6 lines, -3 lines 1 comment Download
M content/public/browser/url_data_source.h View 3 chunks +5 lines, -12 lines 0 comments Download
M content/public/browser/url_data_source.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ios/web/public/url_data_source_ios.h View 2 chunks +3 lines, -11 lines 0 comments Download
M ios/web/webui/url_data_manager_ios_backend.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ios/web/webui/url_data_source_ios.mm View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
jam
3 years, 7 months ago (2017-05-03 20:44:05 UTC) #4
yzshen1
LGTM with two nits. https://codereview.chromium.org/2856093004/diff/1/chrome/browser/search/iframe_source_unittest.cc File chrome/browser/search/iframe_source_unittest.cc (right): https://codereview.chromium.org/2856093004/diff/1/chrome/browser/search/iframe_source_unittest.cc#newcode102 chrome/browser/search/iframe_source_unittest.cc:102: bool ShouldService(const std::string path, int ...
3 years, 7 months ago (2017-05-03 21:00:19 UTC) #5
jam
https://codereview.chromium.org/2856093004/diff/1/chrome/browser/search/iframe_source_unittest.cc File chrome/browser/search/iframe_source_unittest.cc (right): https://codereview.chromium.org/2856093004/diff/1/chrome/browser/search/iframe_source_unittest.cc#newcode102 chrome/browser/search/iframe_source_unittest.cc:102: bool ShouldService(const std::string path, int process_id) { On 2017/05/03 ...
3 years, 7 months ago (2017-05-03 21:14:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856093004/20001
3 years, 7 months ago (2017-05-03 21:15:37 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/cf6f762f05c3d4aab0e127e556ab7852273d9807
3 years, 7 months ago (2017-05-03 22:16:50 UTC) #14
Dan Beam
3 years, 7 months ago (2017-05-03 22:33:38 UTC) #16
Message was sent while issue was closed.
https://codereview.chromium.org/2856093004/diff/20001/content/browser/webui/u...
File content/browser/webui/url_data_manager_backend.cc (right):

https://codereview.chromium.org/2856093004/diff/20001/content/browser/webui/u...
content/browser/webui/url_data_manager_backend.cc:687: info ? info->GetChildID()
: -1)) {
O_o can we use some temporary variables?

Powered by Google App Engine
This is Rietveld 408576698