Generalize content::URLDataSource so that it can be used by the network service.

chrome/browser/search/iframe_source_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search/iframe_source.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/memory/ref_counted_memory.h"
@@ skipping 71 matching lines @@
 
   TestIframeSource* source() { return source_.get(); }
 
   std::string response_string() {
     if (response_.get()) {
       return std::string(response_->front_as<char>(), response_->size());
     }
     return "";
   }
 
-  std::unique_ptr<net::URLRequest> MockRequest(const std::string& url,
-                                               int render_process_id) {
-    std::unique_ptr<net::URLRequest> request(
-        resource_context_.GetRequestContext()->CreateRequest(
-            GURL(url), net::DEFAULT_PRIORITY, NULL,
-            TRAFFIC_ANNOTATION_FOR_TESTS));
-    content::ResourceRequestInfo::AllocateForTesting(
-        request.get(), content::RESOURCE_TYPE_SUB_FRAME, &resource_context_,
-        render_process_id, MSG_ROUTING_NONE, MSG_ROUTING_NONE,
-        /*is_main_frame=*/false,
-        /*parent_is_main_frame=*/false,
-        /*allow_download=*/true,
-        /*is_async=*/false, content::PREVIEWS_OFF);
-    return request;
-  }
-
   void SendResource(int resource_id) {
     source()->SendResource(resource_id, callback_);
   }
 
   void SendJSWithOrigin(int resource_id) {
     source()->SendJSWithOrigin(
         resource_id, content::ResourceRequestInfo::WebContentsGetter(),
         callback_);
   }
 
+  bool ShouldService(const std::string& path, int process_id) {
+    return source()->ShouldServiceRequest(GURL(path), &resource_context_,
+                                          process_id);
+  }
+
  private:
   void SetUp() override {
     source_.reset(new TestIframeSource());
     callback_ = base::Bind(&IframeSourceTest::SaveResponse,
                            base::Unretained(this));
     instant_io_context_ = new InstantIOContext;
     InstantIOContext::SetUserDataOnIO(&resource_context_, instant_io_context_);
     source_->set_origin(kInstantOrigin);
     InstantIOContext::AddInstantProcessOnIO(instant_io_context_,
                                             kInstantRendererPID);
@@ skipping 10 matching lines @@
 
   net::TestURLRequestContext test_url_request_context_;
   content::MockResourceContext resource_context_;
   std::unique_ptr<TestIframeSource> source_;
   content::URLDataSource::GotDataCallback callback_;
   scoped_refptr<InstantIOContext> instant_io_context_;
   scoped_refptr<base::RefCountedMemory> response_;
 };
 
 TEST_F(IframeSourceTest, ShouldServiceRequest) {
-  std::unique_ptr<net::URLRequest> request;
   source()->set_origin(kNonInstantOrigin);
-  request = MockRequest("http://test/loader.js", kNonInstantRendererPID);
-  EXPECT_FALSE(source()->ShouldServiceRequest(request.get()));
+  EXPECT_FALSE(ShouldService("http://test/loader.js", kNonInstantRendererPID));
   source()->set_origin(kInstantOrigin);
-  request = MockRequest("chrome-search://bogus/valid.js", kInstantRendererPID);
-  EXPECT_FALSE(source()->ShouldServiceRequest(request.get()));
+  EXPECT_FALSE(
+      ShouldService("chrome-search://bogus/valid.js", kInstantRendererPID));
   source()->set_origin(kInstantOrigin);
-  request = MockRequest("chrome-search://test/bogus.js", kInstantRendererPID);
-  EXPECT_FALSE(source()->ShouldServiceRequest(request.get()));
+  EXPECT_FALSE(
+      ShouldService("chrome-search://test/bogus.js", kInstantRendererPID));
   source()->set_origin(kInstantOrigin);
-  request = MockRequest("chrome-search://test/valid.js", kInstantRendererPID);
-  EXPECT_TRUE(source()->ShouldServiceRequest(request.get()));
+  EXPECT_TRUE(
+      ShouldService("chrome-search://test/valid.js", kInstantRendererPID));
   source()->set_origin(kNonInstantOrigin);
-  request = MockRequest("chrome-search://test/valid.js",
-                        kNonInstantRendererPID);
-  EXPECT_FALSE(source()->ShouldServiceRequest(request.get()));
+  EXPECT_FALSE(
+      ShouldService("chrome-search://test/valid.js", kNonInstantRendererPID));
   source()->set_origin(std::string());
-  request = MockRequest("chrome-search://test/valid.js", kInvalidRendererPID);
-  EXPECT_FALSE(source()->ShouldServiceRequest(request.get()));
+  EXPECT_FALSE(
+      ShouldService("chrome-search://test/valid.js", kInvalidRendererPID));
 }
 
 TEST_F(IframeSourceTest, GetMimeType) {
   // URLDataManagerBackend does not include / in path_and_query.
   EXPECT_EQ("text/html", source()->GetMimeType("foo.html"));
   EXPECT_EQ("application/javascript", source()->GetMimeType("foo.js"));
   EXPECT_EQ("text/css", source()->GetMimeType("foo.css"));
   EXPECT_EQ("image/png", source()->GetMimeType("foo.png"));
   EXPECT_EQ("", source()->GetMimeType("bogus"));
 }
 
 TEST_F(IframeSourceTest, SendResource) {
   SendResource(IDR_MOST_VISITED_TITLE_HTML);
   EXPECT_FALSE(response_string().empty());
 }
 
 TEST_F(IframeSourceTest, SendJSWithOrigin) {
   source()->set_origin(kInstantOrigin);
   SendJSWithOrigin(IDR_MOST_VISITED_TITLE_JS);
   EXPECT_FALSE(response_string().empty());
   source()->set_origin(kNonInstantOrigin);
   SendJSWithOrigin(IDR_MOST_VISITED_TITLE_JS);
   EXPECT_FALSE(response_string().empty());
   source()->set_origin(std::string());
   SendJSWithOrigin(IDR_MOST_VISITED_TITLE_JS);
   EXPECT_TRUE(response_string().empty());
 }