Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2856083003: Revert of Add list of plugged-in USB devices to feedback reports (Closed)

Created:
3 years, 7 months ago by afakhry
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add list of plugged-in USB devices to feedback reports (patchset #1 id:1 of https://codereview.chromium.org/2856813002/ ) Reason for revert: It's better to modify the entry in log_tool.cc on debugd. Original issue's description: > Add list of plugged-in USB devices to feedback reports > > This will allow us to track which USB devices are plugged in > and if they're going through hubs. > > BUG=695523 > TEST=Sys info in feedback reports should have an entry "usb_devices: > > Review-Url: https://codereview.chromium.org/2856813002 > Cr-Commit-Position: refs/heads/master@{#468683} > Committed: https://chromium.googlesource.com/chromium/src/+/31a45636e84fdf6cf56cac35ece3604baddf9174 TBR=xiyuan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=695523 Review-Url: https://codereview.chromium.org/2856083003 Cr-Commit-Position: refs/heads/master@{#469052} Committed: https://chromium.googlesource.com/chromium/src/+/d4c0e7cb46c3102fb4845db60de085daf74c10f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/chromeos/system_logs/command_line_log_source.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
afakhry
Created Revert of Add list of plugged-in USB devices to feedback reports
3 years, 7 months ago (2017-05-03 18:04:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856083003/1
3 years, 7 months ago (2017-05-03 18:05:03 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:48:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d4c0e7cb46c3102fb4845db60de0...

Powered by Google App Engine
This is Rietveld 408576698