Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2856813002: Add list of plugged-in USB devices to feedback reports (Closed)

Created:
3 years, 7 months ago by afakhry
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add list of plugged-in USB devices to feedback reports This will allow us to track which USB devices are plugged in and if they're going through hubs. BUG=695523 TEST=Sys info in feedback reports should have an entry "usb_devices: Review-Url: https://codereview.chromium.org/2856813002 Cr-Commit-Position: refs/heads/master@{#468683} Committed: https://chromium.googlesource.com/chromium/src/+/31a45636e84fdf6cf56cac35ece3604baddf9174

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chromeos/system_logs/command_line_log_source.cc View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
afakhry
Xiyuan, could you please take a look? Thanks!
3 years, 7 months ago (2017-05-02 00:40:16 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/2856813002/diff/1/chrome/browser/chromeos/system_logs/command_line_log_source.cc File chrome/browser/chromeos/system_logs/command_line_log_source.cc (right): https://codereview.chromium.org/2856813002/diff/1/chrome/browser/chromeos/system_logs/command_line_log_source.cc#newcode87 chrome/browser/chromeos/system_logs/command_line_log_source.cc:87: commands.emplace_back("usb_devices", command); Do you want to update other ...
3 years, 7 months ago (2017-05-02 06:07:04 UTC) #3
afakhry
On 2017/05/02 06:07:04, xiyuan wrote: > lgtm > > https://codereview.chromium.org/2856813002/diff/1/chrome/browser/chromeos/system_logs/command_line_log_source.cc > File chrome/browser/chromeos/system_logs/command_line_log_source.cc (right): > ...
3 years, 7 months ago (2017-05-02 16:24:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856813002/1
3 years, 7 months ago (2017-05-02 16:25:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/31a45636e84fdf6cf56cac35ece3604baddf9174
3 years, 7 months ago (2017-05-02 16:56:19 UTC) #9
afakhry
3 years, 7 months ago (2017-05-03 18:04:09 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2856083003/ by afakhry@chromium.org.

The reason for reverting is: It's better to modify the entry in log_tool.cc on
debugd..

Powered by Google App Engine
This is Rietveld 408576698