Add list of plugged-in USB devices to feedback reports

Add list of plugged-in USB devices to feedback reports

This will allow us to track which USB devices are plugged in
and if they're going through hubs.

BUG=695523
TEST=Sys info in feedback reports should have an entry "usb_devices:

Review-Url: https://codereview.chromium.org/2856813002
Cr-Commit-Position: refs/heads/master@{#468683}
Committed: https://chromium.googlesource.com/chromium/src/+/31a45636e84fdf6cf56cac35ece3604baddf9174

[afakhry, 2017-05-02 00:40:16]

afakhry@chromium.org changed reviewers:
+ xiyuan@chromium.org

[afakhry, 2017-05-02 00:40:16]

Xiyuan, could you please take a look? Thanks!

[xiyuan, 2017-05-02 06:07:04]

lgtm

https://codereview.chromium.org/2856813002/diff/1/chrome/browser/chromeos/sys...
File chrome/browser/chromeos/system_logs/command_line_log_source.cc (right):

https://codereview.chromium.org/2856813002/diff/1/chrome/browser/chromeos/sys...
chrome/browser/chromeos/system_logs/command_line_log_source.cc:87:
commands.emplace_back("usb_devices", command);
Do you want to update other push_back s ?

[afakhry, 2017-05-02 16:24:17]

On 2017/05/02 06:07:04, xiyuan wrote:
> lgtm
> 
>
https://codereview.chromium.org/2856813002/diff/1/chrome/browser/chromeos/sys...
> File chrome/browser/chromeos/system_logs/command_line_log_source.cc (right):
> 
>
https://codereview.chromium.org/2856813002/diff/1/chrome/browser/chromeos/sys...
> chrome/browser/chromeos/system_logs/command_line_log_source.cc:87:
> commands.emplace_back("usb_devices", command);
> Do you want to update other push_back s ?

Yes. I have that already in another CL:
https://codereview.chromium.org/2844223005/

[afakhry, 2017-05-02 16:25:01]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2017-05-02 16:25:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 16:56:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493742301532280, "parent_rev":
"f039f8a06fa8cc245069c61d2d017c1f40a74d85", "commit_rev":
"31a45636e84fdf6cf56cac35ece3604baddf9174"}

[commit-bot: I haz the power, 2017-05-02 16:56:19]

Description was changed from

==========
Add list of plugged-in USB devices to feedback reports

This will allow us to track which USB devices are plugged in
and if they're going through hubs.

BUG=695523
TEST=Sys info in feedback reports should have an entry "usb_devices:
==========

to

==========
Add list of plugged-in USB devices to feedback reports

This will allow us to track which USB devices are plugged in
and if they're going through hubs.

BUG=695523
TEST=Sys info in feedback reports should have an entry "usb_devices:

Review-Url: https://codereview.chromium.org/2856813002
Cr-Commit-Position: refs/heads/master@{#468683}
Committed:
https://chromium.googlesource.com/chromium/src/+/31a45636e84fdf6cf56cac35ece3...
==========

[commit-bot: I haz the power, 2017-05-02 16:56:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/31a45636e84fdf6cf56cac35ece3...

[afakhry, 2017-05-03 18:04:09]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2856083003/ by afakhry@chromium.org.

The reason for reverting is: It's better to modify the entry in log_tool.cc on
debugd..