Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2856043002: cc : Layers with singular transforms and copy request should be drawn (Closed)

Created:
3 years, 7 months ago by jaydasika
Modified:
3 years, 7 months ago
Reviewers:
weiliangc, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, vmpstr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Layers with singular transforms and copy request should be drawn https://codereview.chromium.org/2838033002/ unintentionally removed layers with singular transform and copy requests from the list of layers that draw. This CL fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2856043002 Cr-Commit-Position: refs/heads/master@{#469184} Committed: https://chromium.googlesource.com/chromium/src/+/96e6946fbce26ef707a1c37f935be1b011a57ded

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -52 lines) Patch
M cc/trees/draw_property_utils.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/effect_node.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/effect_node.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 2 chunks +23 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M cc/trees/property_tree.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/property_tree.cc View 1 2 chunks +1 line, -16 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 4 chunks +38 lines, -27 lines 1 comment Download

Messages

Total messages: 20 (14 generated)
jaydasika
PTAL
3 years, 7 months ago (2017-05-03 00:34:02 UTC) #4
weiliangc
https://codereview.chromium.org/2856043002/diff/1/cc/trees/effect_node.h File cc/trees/effect_node.h (right): https://codereview.chromium.org/2856043002/diff/1/cc/trees/effect_node.h#newcode67 cc/trees/effect_node.h:67: int closest_ancestor_with_copy_request_id; Is it possible to make this acts ...
3 years, 7 months ago (2017-05-03 17:34:16 UTC) #9
jaydasika
https://codereview.chromium.org/2856043002/diff/1/cc/trees/effect_node.h File cc/trees/effect_node.h (right): https://codereview.chromium.org/2856043002/diff/1/cc/trees/effect_node.h#newcode67 cc/trees/effect_node.h:67: int closest_ancestor_with_copy_request_id; On 2017/05/03 17:34:16, weiliangc wrote: > Is ...
3 years, 7 months ago (2017-05-03 21:14:33 UTC) #10
weiliangc
LGTM
3 years, 7 months ago (2017-05-03 21:26:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856043002/20001
3 years, 7 months ago (2017-05-03 23:00:11 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 23:07:03 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/96e6946fbce26ef707a1c37f935b...

Powered by Google App Engine
This is Rietveld 408576698