cc/trees/effect_node.h - Issue 2856043002: cc : Layers with singular transforms and copy request should be drawn

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/trees/effect_node.h

Issue 2856043002: cc : Layers with singular transforms and copy request should be drawn (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_TREES_EFFECT_NODE_H_	5 #ifndef CC_TREES_EFFECT_NODE_H_

6 #define CC_TREES_EFFECT_NODE_H_	6 #define CC_TREES_EFFECT_NODE_H_

7	7

8 #include "cc/base/filter_operations.h"	8 #include "cc/base/filter_operations.h"

9 #include "cc/cc_export.h"	9 #include "cc/cc_export.h"

10 #include "third_party/skia/include/core/SkBlendMode.h"	10 #include "third_party/skia/include/core/SkBlendMode.h"

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 bool is_currently_animating_opacity;	57 bool is_currently_animating_opacity;

58 // We need to track changes to effects on the compositor to compute damage	58 // We need to track changes to effects on the compositor to compute damage

59 // rect.	59 // rect.

60 bool effect_changed;	60 bool effect_changed;

61 bool subtree_has_copy_request;	61 bool subtree_has_copy_request;

62 int transform_id;	62 int transform_id;

63 int clip_id;	63 int clip_id;

64 // Effect node id of which this effect contributes to.	64 // Effect node id of which this effect contributes to.

65 int target_id;	65 int target_id;

66 int mask_layer_id;	66 int mask_layer_id;

	67 int closest_ancestor_with_copy_request_id;
	weiliangc 2017/05/03 17:34:16 Is it possible to make this acts more similar to s Is it possible to make this acts more similar to subtree_has_copy_request? Updated at the same time, and close to each other in code, since they should be in sync? jaydasika 2017/05/03 21:14:33 Done. Show quoted text On 2017/05/03 17:34:16, weiliangc wrote: > Is it possible to make this acts more similar to subtree_has_copy_request? > Updated at the same time, and close to each other in code, since they should be > in sync? Done.
67	68

68 bool operator==(const EffectNode& other) const;	69 bool operator==(const EffectNode& other) const;

69	70

70 void AsValueInto(base::trace_event::TracedValue* value) const;	71 void AsValueInto(base::trace_event::TracedValue* value) const;

71 };	72 };

72	73

73 } // namespace cc	74 } // namespace cc

74	75

75 #endif // CC_TREES_EFFECT_NODE_H_	76 #endif // CC_TREES_EFFECT_NODE_H_

OLD	NEW

« no previous file with comments | « cc/trees/draw_property_utils.cc ('k') | cc/trees/effect_node.cc » ('j') | no next file with comments »