Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2856023003: Make UiElement a class (Closed)

Created:
3 years, 7 months ago by Ian Vollick
Modified:
3 years, 7 months ago
Reviewers:
cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make UiElement a class BUG=None Review-Url: https://codereview.chromium.org/2856023003 Cr-Commit-Position: refs/heads/master@{#469272} Committed: https://chromium.googlesource.com/chromium/src/+/30e40b017ed7905c3bd08cef5e36003ed285d618

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -246 lines) Patch
M chrome/browser/android/vr_shell/ui_elements/textured_element.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/ui_element.h View 3 chunks +137 lines, -26 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/ui_element.cc View 5 chunks +31 lines, -27 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/ui_element_unittest.cc View 6 chunks +30 lines, -28 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.cc View 1 10 chunks +41 lines, -40 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 8 chunks +60 lines, -62 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_unittest.cc View 5 chunks +44 lines, -44 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 4 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
Ian Vollick
On 2017/05/03 16:05:18, Ian Vollick wrote: > mailto:vollick@chromium.org changed reviewers: > + mailto:cjgrant@chromium.org I've broken ...
3 years, 7 months ago (2017-05-03 16:05:50 UTC) #3
cjgrant
lgtm
3 years, 7 months ago (2017-05-03 16:07:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856023003/1
3 years, 7 months ago (2017-05-03 22:57:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/426900)
3 years, 7 months ago (2017-05-03 23:08:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856023003/20001
3 years, 7 months ago (2017-05-04 05:12:33 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 05:17:47 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/30e40b017ed7905c3bd08cef5e36...

Powered by Google App Engine
This is Rietveld 408576698