Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2855963002: DevTools: appropriately hide the source map infobar (Closed)

Created:
3 years, 7 months ago by luoe
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: appropriately hide the source map infobar After changing source map infobar's trigger, a mistake in the logic led to the infobar showing up even when it should not. Logic changed in: https://codereview.chromium.org/2851483003 BUG=716340 Review-Url: https://codereview.chromium.org/2855963002 Cr-Commit-Position: refs/heads/master@{#468795} Committed: https://chromium.googlesource.com/chromium/src/+/95800412eeae82fb9ebf3779c4b9846bd44e401b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
luoe
Please take a look. My mistake on this one for not testing more thoroughly.
3 years, 7 months ago (2017-05-02 20:43:20 UTC) #2
dgozman
lgtm
3 years, 7 months ago (2017-05-02 20:52:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855963002/1
3 years, 7 months ago (2017-05-02 22:24:09 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 22:28:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95800412eeae82fb9ebf3779c4b9...

Powered by Google App Engine
This is Rietveld 408576698