Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2851483003: DevTools: only show one source map infobar at a time (Closed)

Created:
3 years, 7 months ago by luoe
Modified:
3 years, 7 months ago
Reviewers:
dgozman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: only show one source map infobar at a time The 'Source map detected' infobar is created when a script with a sourcemap is updated. When Persistence is enabled, this may happen each time the user refreshes the page, resulting in many duplicate infobars. This CL checks for an existing sourceMapInfobar before creating a new one, or removes it if the updated script has no sourcemap. BUG=716340 Review-Url: https://codereview.chromium.org/2851483003 Cr-Commit-Position: refs/heads/master@{#468509} Committed: https://chromium.googlesource.com/chromium/src/+/15d1662e1a70f83a71e629aa7daa43c3d887dcd0

Patch Set 1 : DevTools: only show one source map infobar at a time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +31 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
luoe
Please take a look
3 years, 7 months ago (2017-04-29 03:34:14 UTC) #5
dgozman
lgtm
3 years, 7 months ago (2017-05-01 18:40:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851483003/40001
3 years, 7 months ago (2017-05-01 18:41:32 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 00:43:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/15d1662e1a70f83a71e629aa7daa...

Powered by Google App Engine
This is Rietveld 408576698