Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: third_party/WebKit/Source/core/loader/resource/ImageResource.h

Issue 2855883004: Rename Resource::GetError() to FinishAsError() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/resource/ImageResource.h
diff --git a/third_party/WebKit/Source/core/loader/resource/ImageResource.h b/third_party/WebKit/Source/core/loader/resource/ImageResource.h
index 2df41d23683fa6eb12cb25a2e1511b2a832049a0..cd08f6e1ae16e97eec23731808baa2cc7189ec57 100644
--- a/third_party/WebKit/Source/core/loader/resource/ImageResource.h
+++ b/third_party/WebKit/Source/core/loader/resource/ImageResource.h
@@ -83,7 +83,7 @@ class CORE_EXPORT ImageResource final
PassRefPtr<const SharedBuffer> ResourceBuffer() const override;
void AppendData(const char*, size_t) override;
- void GetError(const ResourceError&) override;
+ void FinishAsError(const ResourceError&) override;
Nate Chapin 2017/05/02 22:59:31 Optional: Reorder these callbacks so that they're
hiroshige 2017/05/04 18:39:18 Done.
void ResponseReceived(const ResourceResponse&,
std::unique_ptr<WebDataConsumerHandle>) override;
void Finish(double finish_time = 0.0) override;

Powered by Google App Engine
This is Rietveld 408576698