third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp - Issue 2855883004: Rename Resource::GetError() to FinishAsError()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp

Issue 2855883004: Rename Resource::GetError() to FinishAsError() (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/resource/ImageResource.h » ('j') | third_party/WebKit/Source/core/loader/resource/ImageResource.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp b/third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp

index 6d00f396201988a2d0a20241835ad4cf65ed3400..bc6012f3aec1e2b0385ec489c2d16ed7736ec7cd 100644

--- a/third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp

+++ b/third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp

@@ -143,7 +143,7 @@ TEST_F(CSSPreloadScannerTest, DontReadFromClearedData) {

const char* data = "@import url('http://127.0.0.1/preload.css');";

resource->AppendData(data, strlen(data));

ResourceError error(kErrorDomainBlinkInternal, 0, url.GetString(), "");

- resource->GetError(error);

+ resource->FinishAsError(error);

// Should not crash.

PreloadRecordingCSSPreloaderResourceClient* resource_client =