Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2855753002: Simplify HTMLPlugInElement::PluginWrapper to not use SharedPersistent. (Closed)

Created:
3 years, 7 months ago by jbroman
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify HTMLPlugInElement::PluginWrapper to not use SharedPersistent. This handle is always uniquely owned, anyhow. And the indirection through ScriptController adds very little value. BUG=None Review-Url: https://codereview.chromium.org/2855753002 Cr-Commit-Position: refs/heads/master@{#468625} Committed: https://chromium.googlesource.com/chromium/src/+/8569024f3f1ef296d6614c9482b9de6ed14b3ced

Patch Set 1 #

Patch Set 2 : no need for mutable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -38 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 2 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
jbroman
The use of SharedPersistent (which is ref-counted) here is overkill. Simplify by just using v8::Local/Global ...
3 years, 7 months ago (2017-05-01 23:24:17 UTC) #6
haraken
LGTM
3 years, 7 months ago (2017-05-02 04:45:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855753002/20001
3 years, 7 months ago (2017-05-02 13:58:17 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 14:02:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8569024f3f1ef296d6614c9482b9...

Powered by Google App Engine
This is Rietveld 408576698