Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

Issue 2855753002: Simplify HTMLPlugInElement::PluginWrapper to not use SharedPersistent. (Closed)
Patch Set: no need for mutable Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
index 5932b286a897ef8ed069a3ab2ab1b37727549ac7..ebda7e920cd536a100100296372b648302833037 100644
--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
@@ -50,7 +50,7 @@ class CORE_EXPORT HTMLPlugInElement : public HTMLFrameOwnerElement {
void ResetInstance();
// TODO(dcheng): Consider removing this, since HTMLEmbedElementLegacyCall
// and HTMLObjectElementLegacyCall usage is extremely low.
- SharedPersistent<v8::Object>* PluginWrapper();
+ v8::Local<v8::Object> PluginWrapper();
// TODO(joelhockey): Clean up pluginWidget and plugin (maybe also
// pluginWrapper). It would be good to remove and/or rename some of these.
// pluginWidget and plugin both return the plugin that is stored on this
@@ -174,7 +174,7 @@ class CORE_EXPORT HTMLPlugInElement : public HTMLFrameOwnerElement {
const Vector<String>& param_names,
const Vector<String>& param_values);
- mutable RefPtr<SharedPersistent<v8::Object>> plugin_wrapper_;
+ v8::Global<v8::Object> plugin_wrapper_;
bool needs_plugin_update_;
bool should_prefer_plug_ins_for_images_;
// Represents |layoutObject() && layoutObject()->isEmbeddedObject() &&

Powered by Google App Engine
This is Rietveld 408576698