chrome/browser/ui/views/extensions/request_file_system_dialog_view.h - Issue 2855663002: Fix the memory leak in the RequestFileSystemDialogTest reported by the Chrome OS ASAN builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/request_file_system_dialog_view.h

Issue 2855663002: Fix the memory leak in the RequestFileSystemDialogTest reported by the Chrome OS ASAN builder. (Closed)

Patch Set: Remove the unused contents_view_ member from the RequestFileSystemDialogView class as it is no long… Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/extensions/request_file_system_dialog_view.h

diff --git a/chrome/browser/ui/views/extensions/request_file_system_dialog_view.h b/chrome/browser/ui/views/extensions/request_file_system_dialog_view.h

index 5c3de0e99444c531313207e456f8cd9fbbb667e9..ff3ad7b2fd85559014673bafb4dec708fa4379f0 100644

--- a/chrome/browser/ui/views/extensions/request_file_system_dialog_view.h

+++ b/chrome/browser/ui/views/extensions/request_file_system_dialog_view.h

@@ -51,7 +51,6 @@ class RequestFileSystemDialogView : public views::DialogDelegateView {

const base::Callback<void(ui::DialogButton)>& callback);

const base::Callback<void(ui::DialogButton)> callback_;

- views::View* const contents_view_;

DISALLOW_COPY_AND_ASSIGN(RequestFileSystemDialogView);

};

« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc » ('j') | no next file with comments »