chrome/browser/ui/views/extensions/request_file_system_dialog_view.h - Issue 2855663002: Fix the memory leak in the RequestFileSystemDialogTest reported by the Chrome OS ASAN builder.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/extensions/request_file_system_dialog_view.h

Issue 2855663002: Fix the memory leak in the RequestFileSystemDialogTest reported by the Chrome OS ASAN builder. (Closed)

Patch Set: Remove the unused contents_view_ member from the RequestFileSystemDialogView class as it is no long… Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_	5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_

6 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_	6 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_

7	7

8 #include "base/callback_forward.h"	8 #include "base/callback_forward.h"

9 #include "base/macros.h"	9 #include "base/macros.h"

10 #include "base/memory/weak_ptr.h"	10 #include "base/memory/weak_ptr.h"

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 gfx::Insets GetInsets() const override;	44 gfx::Insets GetInsets() const override;

45	45

46 private:	46 private:

47 RequestFileSystemDialogView(	47 RequestFileSystemDialogView(

48 const std::string& extension_name,	48 const std::string& extension_name,

49 const std::string& volume_label,	49 const std::string& volume_label,

50 bool writable,	50 bool writable,

51 const base::Callback<void(ui::DialogButton)>& callback);	51 const base::Callback<void(ui::DialogButton)>& callback);

52	52

53 const base::Callback<void(ui::DialogButton)> callback_;	53 const base::Callback<void(ui::DialogButton)> callback_;

54 views::View* const contents_view_;

55	54

56 DISALLOW_COPY_AND_ASSIGN(RequestFileSystemDialogView);	55 DISALLOW_COPY_AND_ASSIGN(RequestFileSystemDialogView);

57 };	56 };

58	57

59 #endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_	58 #endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_REQUEST_FILE_SYSTEM_DIALOG_VIEW_H_

OLD	NEW