chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc - Issue 2855663002: Fix the memory leak in the RequestFileSystemDialogTest reported by the Chrome OS ASAN builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc

Issue 2855663002: Fix the memory leak in the RequestFileSystemDialogTest reported by the Chrome OS ASAN builder. (Closed)

Patch Set: Remove the unused contents_view_ member from the RequestFileSystemDialogView class as it is no long… Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc b/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc

index 3b0902030f94a2a52050e03e66ad4aeacd7e9766..7ce2ab453dbde6e3c47053e972dcdf98d8a76e81 100644

--- a/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc

@@ -94,7 +94,7 @@ RequestFileSystemDialogView::RequestFileSystemDialogView(

const std::string& volume_label,

bool writable,

const base::Callback<void(ui::DialogButton)>& callback)

- : callback_(callback), contents_view_(new views::View) {

+ : callback_(callback) {

DCHECK(!callback_.is_null());

const base::string16 app_name = base::UTF8ToUTF16(extension_name);

« no previous file with comments | « chrome/browser/ui/views/extensions/request_file_system_dialog_view.h ('k') | no next file » | no next file with comments »