Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2855623005: Move browsing_data counter sync tests to separate file (Closed)

Created:
3 years, 7 months ago by dullweber
Modified:
3 years, 7 months ago
Reviewers:
msramek
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move browsing_data counter sync tests to separate file The history, passwords and autofill counters currently each have a test to check if they behave correctly when different sets of datatypes are being synced. This required the whole test class to be a SyncTest. This change moves these sync related tests to a separate test file, reverts the other tests to normal InProcessBrowserTests and removes all unnecessary helper methods from these tests. BUG=717443 Review-Url: https://codereview.chromium.org/2855623005 Cr-Commit-Position: refs/heads/master@{#472066} Committed: https://chromium.googlesource.com/chromium/src/+/52b329c5fe6e273189927ef663f56304a65ceef8

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : remove HistoryResult and PasswordResult #

Total comments: 7

Patch Set 4 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -369 lines) Patch
M chrome/browser/browsing_data/autofill_counter_browsertest.cc View 8 chunks +2 lines, -91 lines 0 comments Download
M chrome/browser/browsing_data/history_counter_browsertest.cc View 1 2 3 11 chunks +19 lines, -127 lines 0 comments Download
M chrome/browser/browsing_data/passwords_counter_browsertest.cc View 1 2 8 chunks +7 lines, -102 lines 0 comments Download
A chrome/browser/browsing_data/sync_aware_counter_browsertest.cc View 1 2 3 1 chunk +327 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/browsing_data/core/browsing_data_utils.cc View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M components/browsing_data/core/browsing_data_utils_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/browsing_data/core/counters/autofill_counter.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/browsing_data/core/counters/autofill_counter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/browsing_data/core/counters/browsing_data_counter.h View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M components/browsing_data/core/counters/browsing_data_counter.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M components/browsing_data/core/counters/history_counter.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M components/browsing_data/core/counters/history_counter.cc View 1 2 3 3 chunks +11 lines, -10 lines 0 comments Download
M components/browsing_data/core/counters/passwords_counter.h View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M components/browsing_data/core/counters/passwords_counter.cc View 1 2 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 31 (23 generated)
dullweber
Hi Martin, I moved all sync related counter tests to a separate test file
3 years, 7 months ago (2017-05-11 13:22:19 UTC) #15
msramek
https://codereview.chromium.org/2855623005/diff/40001/chrome/browser/browsing_data/sync_aware_counter_browsertest.cc File chrome/browser/browsing_data/sync_aware_counter_browsertest.cc (right): https://codereview.chromium.org/2855623005/diff/40001/chrome/browser/browsing_data/sync_aware_counter_browsertest.cc#newcode1 chrome/browser/browsing_data/sync_aware_counter_browsertest.cc:1: // Copyright (c) 2015 The Chromium Authors. All rights ...
3 years, 7 months ago (2017-05-11 15:49:14 UTC) #16
dullweber
Thanks, all done https://codereview.chromium.org/2855623005/diff/40001/chrome/browser/browsing_data/sync_aware_counter_browsertest.cc File chrome/browser/browsing_data/sync_aware_counter_browsertest.cc (right): https://codereview.chromium.org/2855623005/diff/40001/chrome/browser/browsing_data/sync_aware_counter_browsertest.cc#newcode1 chrome/browser/browsing_data/sync_aware_counter_browsertest.cc:1: // Copyright (c) 2015 The Chromium ...
3 years, 7 months ago (2017-05-12 13:37:31 UTC) #19
msramek
LGTM, thanks for the cleanup! https://codereview.chromium.org/2855623005/diff/40001/components/browsing_data/core/counters/browsing_data_counter.cc File components/browsing_data/core/counters/browsing_data_counter.cc (right): https://codereview.chromium.org/2855623005/diff/40001/components/browsing_data/core/counters/browsing_data_counter.cc#newcode179 components/browsing_data/core/counters/browsing_data_counter.cc:179: bool BrowsingDataCounter::SyncResult::IsSyncEnabled() const { ...
3 years, 7 months ago (2017-05-15 17:56:53 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855623005/60001
3 years, 7 months ago (2017-05-16 07:50:10 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/427642)
3 years, 7 months ago (2017-05-16 08:47:08 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855623005/60001
3 years, 7 months ago (2017-05-16 11:29:17 UTC) #28
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 12:25:00 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/52b329c5fe6e273189927ef663f5...

Powered by Google App Engine
This is Rietveld 408576698