Move browsing_data counter sync tests to separate file

components/browsing_data/core/counters/browsing_data_counter.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/browsing_data/core/counters/browsing_data_counter.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "components/browsing_data/core/browsing_data_utils.h"
@@ skipping 149 matching lines @@
 
 bool BrowsingDataCounter::FinishedResult::Finished() const {
   return true;
 }
 
 BrowsingDataCounter::ResultInt BrowsingDataCounter::FinishedResult::Value()
     const {
   return value_;
 }
 
+// BrowsingDataCounter::SyncResult -----------------------------------------
+
+BrowsingDataCounter::SyncResult::SyncResult(const BrowsingDataCounter* source,
+                                            ResultInt value,
+                                            bool sync_enabled)
+    : FinishedResult(source, value), sync_enabled_(sync_enabled) {}
+
+BrowsingDataCounter::SyncResult::~SyncResult() {}
+
+bool BrowsingDataCounter::SyncResult::IsSyncEnabled() const {

[msramek, 2017/05/11 15:49:14]

style nit: Simple non-virtual getters and setters matching the format

set_x(X x) { x_ = x; };

and

get_x() const { return x_ };

are typically underscore_case and in the .h file.

[dullweber, 2017/05/12 13:37:31]

done. Is Value() using the wrong style then?

[msramek, 2017/05/15 17:56:53]

Hmm, apparently so. It was probably virtual at one point.

+  return sync_enabled_;
+}
+
 }  // namespace browsing_data