🔍 Add basic SearchActivityTests

🔍 Add basic SearchActivityTests

Add a basic set of tests that start up the SearchActivity, confirming
that it starts up the browser for URLs and shows the suggestions
container when something is typed in the omnibox.

BUG=70884, 717327
Review-Url: https://codereview.chromium.org/2855543005
Cr-Commit-Position: refs/heads/master@{#469049}
Committed: https://chromium.googlesource.com/chromium/src/+/0d2c7dd94efea54c26b8a935777c982bc1d3bb7f

[gone, 2017-05-02 06:40:24]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 06:40:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-05-02 06:45:59]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 06:46:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-05-02 06:46:39]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org, yusufo@chromium.org

[gone, 2017-05-02 06:46:40]

These tests fail with your patch, so... yay, I guess.

[commit-bot: I haz the power, 2017-05-02 08:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 08:29:32]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-05-02 19:59:01]

lgtm

https://codereview.chromium.org/2855543005/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java
(right):

https://codereview.chromium.org/2855543005/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java:98:
setUrlBarText(searchActivity, "anything.");
I assume with echo suggest it doesn't actually matter if there is no internet
right?

https://codereview.chromium.org/2855543005/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java:128:
// TODO(dfalcantara): Figure out how to confirm the URL is loaded in a non-flaky
way.
can you use a chrome:// URL or about:blank instead of google.com?  Otherwise, I
think you'll not be able to add this ever as it would fail on devices.  Or maybe
we should start the embed web server and use one of our test pages?

ChromeTabUtils#waitForTabPageLoaded should work to wait for page load though

[gone, 2017-05-02 20:36:19]

https://codereview.chromium.org/2855543005/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java
(right):

https://codereview.chromium.org/2855543005/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java:98:
setUrlBarText(searchActivity, "anything.");
On 2017/05/02 19:59:01, Ted C wrote:
> I assume with echo suggest it doesn't actually matter if there is no internet
> right?

Yeah, it just shows the same thing back.

https://codereview.chromium.org/2855543005/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java:128:
// TODO(dfalcantara): Figure out how to confirm the URL is loaded in a non-flaky
way.
On 2017/05/02 19:59:01, Ted C wrote:
> can you use a chrome:// URL or about:blank instead of google.com?  Otherwise,
I
> think you'll not be able to add this ever as it would fail on devices.  Or
maybe
> we should start the embed web server and use one of our test pages?
> 
> ChromeTabUtils#waitForTabPageLoaded should work to wait for page load though

Went with about:blank and checking for the URL in the tab.  Seems to work.

[gone, 2017-05-02 20:36:22]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-05-02 20:36:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2855543005/#ps40001
(title: "Comments")

[commit-bot: I haz the power, 2017-05-02 20:36:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 22:43:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 22:43:25]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gone, 2017-05-02 23:48:59]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 23:49:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 00:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 00:53:38]

Dry run: This issue passed the CQ dry run.

[gone, 2017-05-03 17:17:01]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-05-03 17:17:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2855543005/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-03 17:17:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 18:45:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493831821906080,
"parent_rev": "dba5cb7d9fe8705651cb0d04895dbb8ea1691421", "commit_rev":
"0d2c7dd94efea54c26b8a935777c982bc1d3bb7f"}

[commit-bot: I haz the power, 2017-05-03 18:45:34]

Description was changed from

==========
🔍 Add basic SearchActivityTests

Add a basic set of tests that start up the SearchActivity, confirming
that it starts up the browser for URLs and shows the suggestions
container when something is typed in the omnibox.

BUG=708844
==========

to

==========
🔍 Add basic SearchActivityTests

Add a basic set of tests that start up the SearchActivity, confirming
that it starts up the browser for URLs and shows the suggestions
container when something is typed in the omnibox.

BUG=708844

Review-Url: https://codereview.chromium.org/2855543005
Cr-Commit-Position: refs/heads/master@{#469049}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d2c7dd94efea54c26b8a935777c...
==========

[commit-bot: I haz the power, 2017-05-03 18:45:35]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0d2c7dd94efea54c26b8a935777c...

[gone, 2017-05-03 18:46:32]

Description was changed from

==========
🔍 Add basic SearchActivityTests

Add a basic set of tests that start up the SearchActivity, confirming
that it starts up the browser for URLs and shows the suggestions
container when something is typed in the omnibox.

BUG=708844

Review-Url: https://codereview.chromium.org/2855543005
Cr-Commit-Position: refs/heads/master@{#469049}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d2c7dd94efea54c26b8a935777c...
==========

to

==========
🔍 Add basic SearchActivityTests

Add a basic set of tests that start up the SearchActivity, confirming
that it starts up the browser for URLs and shows the suggestions
container when something is typed in the omnibox.

BUG=70884,717327

Review-Url: https://codereview.chromium.org/2855543005
Cr-Commit-Position: refs/heads/master@{#469049}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d2c7dd94efea54c26b8a935777c...
==========