Defer deferred startup if native isn't loaded

Defer deferred startup if native isn't loaded

There's a race condition that's causing a tab to finish
loading before onStartWithNative has successfully run.
It's not entirely clear where the race condition lies
because the startup pathway is complicated, so prevent
deferred startup from running until native has loaded.

BUG=711708
Review-Url: https://codereview.chromium.org/2855043002
Cr-Commit-Position: refs/heads/master@{#469013}
Committed: https://chromium.googlesource.com/chromium/src/+/1f17747585f90c358df6d8ffbe010893f72d30fc

[gone, 2017-05-02 23:26:44]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[gone, 2017-05-02 23:27:13]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[gone, 2017-05-02 23:27:14]

WDYT?

[commit-bot: I haz the power, 2017-05-02 23:27:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 00:09:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 00:09:50]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-05-03 15:37:39]

lgtm

https://codereview.chromium.org/2855043002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2855043002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:771:
public void onStartWithNative() {
can you add:

assert mNativeInitialized : "Something";

I had to see that finishNativeInitialization was called first and that calls
onStartWithNative indirectly.  Would be good to enforce that contract doesn't
get broken.

[gone, 2017-05-03 16:31:30]

https://codereview.chromium.org/2855043002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2855043002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:771:
public void onStartWithNative() {
On 2017/05/03 15:37:39, Ted C wrote:
> can you add:
> 
> assert mNativeInitialized : "Something";
> 
> I had to see that finishNativeInitialization was called first and that calls
> onStartWithNative indirectly.  Would be good to enforce that contract doesn't
> get broken.

Done.

[gone, 2017-05-03 16:31:34]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-05-03 16:31:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2855043002/#ps40001
(title: "Defer deferred startup if native isn't loaded")

[commit-bot: I haz the power, 2017-05-03 16:32:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 17:14:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493829094227150,
"parent_rev": "996f592abbeaa1b6a14d0fa4073e709cf57b5207", "commit_rev":
"1f17747585f90c358df6d8ffbe010893f72d30fc"}

[commit-bot: I haz the power, 2017-05-03 17:14:28]

Description was changed from

==========
Defer deferred startup if native isn't loaded

There's a race condition that's causing a tab to finish
loading before onStartWithNative has successfully run.
It's not entirely clear where the race condition lies
because the startup pathway is complicated, so prevent
deferred startup from running until native has loaded.

BUG=711708
==========

to

==========
Defer deferred startup if native isn't loaded

There's a race condition that's causing a tab to finish
loading before onStartWithNative has successfully run.
It's not entirely clear where the race condition lies
because the startup pathway is complicated, so prevent
deferred startup from running until native has loaded.

BUG=711708

Review-Url: https://codereview.chromium.org/2855043002
Cr-Commit-Position: refs/heads/master@{#469013}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f17747585f90c358df6d8ffbe01...
==========

[commit-bot: I haz the power, 2017-05-03 17:14:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1f17747585f90c358df6d8ffbe01...