Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2855503002: RELAND: MediaRecorder: enable encode acceleration for VP8 in Android (Closed)

Created:
3 years, 7 months ago by mcasas
Modified:
3 years, 7 months ago
Reviewers:
emircan
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, emircan+watch+mediarecorder_chromium.org, posciak+watch_chromium.org, jam, darin-cc_chromium.org, mcasas+mediarecorder_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

RELAND: MediaRecorder: enable encode acceleration for VP8 in Android This CL relands the CL described below that made an Android bot flakily fail content_browsertests. I could not repro the issue on an emulator locally, but it seems like this test stresses too much (see e.g. https://crbug.com/653864 where the test started failing flakily for no apparent reason). In any case, landing this CL while disabling the test makes sense since the new functionality is stressed in a number of other tests in WebRtcMediaRecorderTest. Also BUG=716691 Original CL description ------------------------------------------------ MediaRecorder: enable encode acceleration for VP8 in Android This is a refry of https://crrev.com/2801803002 (as pointed out in https://crrev.com/2836013006) that enables only VP8 hardware encoding in Android. Tested via webrtc_media_recorder_browsertest.cc [1] [1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_recorder_browsertest.cc?q=webrtc+mediarecorder&sq=package:chromium&dr=CSs&l=27 BUG=638664 Review-Url: https://codereview.chromium.org/2852583002 Cr-Commit-Position: refs/heads/master@{#467879} Committed: https://chromium.googlesource.com/chromium/src/+/6089c73618b3b5010bdb81441c6f5f58936f9e58 patch from issue 2852583002 at patchset 40001 (http://crrev.com/2852583002#ps40001) Review-Url: https://codereview.chromium.org/2855503002 Cr-Commit-Position: refs/heads/master@{#468505} Committed: https://chromium.googlesource.com/chromium/src/+/8d39d3591545ff704fd5473451d873f9598fcb67

Patch Set 1 #

Patch Set 2 : Disable MAYBE_PeerConnection test on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M content/browser/webrtc/webrtc_media_recorder_browsertest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media_recorder/video_track_recorder.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/media_recorder/video_track_recorder.cc View 1 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
mcasas
emircan@ PTAL
3 years, 7 months ago (2017-05-01 22:02:21 UTC) #5
emircan
lgtm
3 years, 7 months ago (2017-05-01 23:38:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855503002/40001
3 years, 7 months ago (2017-05-01 23:40:50 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 00:36:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8d39d3591545ff704fd5473451d8...

Powered by Google App Engine
This is Rietveld 408576698