Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2852583002:
MediaRecorder: enable encode acceleration for VP8 in Android (Closed)
|
Created:
3 years, 7 months ago by mcasas Modified:
3 years, 7 months ago Reviewers:
emircan CC:
chromium-reviews, mlamouri+watch-content_chromium.org, emircan+watch+mediarecorder_chromium.org, posciak+watch_chromium.org, jam, darin-cc_chromium.org, mcasas+mediarecorder_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMediaRecorder: enable encode acceleration for VP8 in Android
This is a refry of https://crrev.com/2801803002 (as pointed out
in https://crrev.com/2836013006) that enables only VP8
hardware encoding in Android.
Tested via webrtc_media_recorder_browsertest.cc [1]
[1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_recorder_browsertest.cc?q=webrtc+mediarecorder&sq=package:chromium&dr=CSs&l=27
BUG=638664
Review-Url: https://codereview.chromium.org/2852583002
Cr-Commit-Position: refs/heads/master@{#467879}
Committed: https://chromium.googlesource.com/chromium/src/+/6089c73618b3b5010bdb81441c6f5f58936f9e58
Patch Set 1 #
Messages
Total messages: 21 (16 generated)
Description was changed from ========== MediaRecorder: enable VP8 VEA for Android enabled vp8 vea in android BUG=638664 ========== to ========== MediaRecorder: enable VP8 VEA for Android This is a refry of https://crrev.com/2801803002 (pointed out in https://crrev.com/2836013006) that enables only VP8 hardware encoding in Android platforms, by avoiding listing as supported anything but. wip BUG=638664 ==========
Description was changed from ========== MediaRecorder: enable VP8 VEA for Android This is a refry of https://crrev.com/2801803002 (pointed out in https://crrev.com/2836013006) that enables only VP8 hardware encoding in Android platforms, by avoiding listing as supported anything but. wip BUG=638664 ========== to ========== MediaRecorder: enable VP8 VEA for Android This is a refry of https://crrev.com/2801803002 (pointed out in https://crrev.com/2836013006) that enables only VP8 hardware encoding in Android platforms by avoiding listing as supported anything but. wip BUG=638664 ==========
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Description was changed from ========== MediaRecorder: enable VP8 VEA for Android This is a refry of https://crrev.com/2801803002 (pointed out in https://crrev.com/2836013006) that enables only VP8 hardware encoding in Android platforms by avoiding listing as supported anything but. wip BUG=638664 ========== to ========== MediaRecorder: enable VP8 VEA for Android This is a refry of https://crrev.com/2801803002 (pointed out in https://crrev.com/2836013006) that enables only VP8 hardware encoding in Android platforms by avoiding listing as supported anything but. Tested via webrtc_media_recorder_browsertest.cc [1] [1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_reco... BUG=638664 ==========
Description was changed from ========== MediaRecorder: enable VP8 VEA for Android This is a refry of https://crrev.com/2801803002 (pointed out in https://crrev.com/2836013006) that enables only VP8 hardware encoding in Android platforms by avoiding listing as supported anything but. Tested via webrtc_media_recorder_browsertest.cc [1] [1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_reco... BUG=638664 ========== to ========== MediaRecorder: enable encode acceleration for VP8 in Android This is a refry of https://crrev.com/2801803002 (as pointed out in https://crrev.com/2836013006) that enables only VP8 hardware encoding in Android. Tested via webrtc_media_recorder_browsertest.cc [1] [1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_reco... BUG=638664 ==========
emircan@chromium.org changed reviewers: + emircan@chromium.org
lgtm
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mcasas@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by mcasas@chromium.org
The CQ bit was checked by mcasas@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493350905276810,
"parent_rev": "3b3ae152b652a7a4240954a07172bd57bdd64a00", "commit_rev":
"6089c73618b3b5010bdb81441c6f5f58936f9e58"}
Message was sent while issue was closed.
Description was changed from ========== MediaRecorder: enable encode acceleration for VP8 in Android This is a refry of https://crrev.com/2801803002 (as pointed out in https://crrev.com/2836013006) that enables only VP8 hardware encoding in Android. Tested via webrtc_media_recorder_browsertest.cc [1] [1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_reco... BUG=638664 ========== to ========== MediaRecorder: enable encode acceleration for VP8 in Android This is a refry of https://crrev.com/2801803002 (as pointed out in https://crrev.com/2836013006) that enables only VP8 hardware encoding in Android. Tested via webrtc_media_recorder_browsertest.cc [1] [1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_media_reco... BUG=638664 Review-Url: https://codereview.chromium.org/2852583002 Cr-Commit-Position: refs/heads/master@{#467879} Committed: https://chromium.googlesource.com/chromium/src/+/6089c73618b3b5010bdb81441c6f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/6089c73618b3b5010bdb81441c6f...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in https://codereview.chromium.org/2846403002/ by khushalsagar@chromium.org. The reason for reverting is: Speculatively reverting since WebRtcMediaRecorderTest.PeerConnection tests on Marshmallow 64 bit Tester have become flaky since the patch landed.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
