Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2855273002:
Make fixed size scrolling more like other lists. (Closed)
|
Created:
3 years, 7 months ago by hcarmona Modified:
3 years, 7 months ago Reviewers:
dschuyler CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake fixed size scrolling more like other lists.
R=scottchen@chromium.org
BUG=NONE
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2855273002
Cr-Commit-Position: refs/heads/master@{#471968}
Committed: https://chromium.googlesource.com/chromium/src/+/1af97c4930cb92df4112db82a79ddacd0041379c
Patch Set 1 #
Total comments: 3
Patch Set 2 : feedback #
Messages
Total messages: 25 (15 generated)
Description was changed from ========== Make fixed size scrolling more like other lists. R=scottchen@chromium.org BUG=NONE ========== to ========== Make fixed size scrolling more like other lists. R=scottchen@chromium.org BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2855273002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (left): https://codereview.chromium.org/2855273002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:231: .fixed-height-list { - Would fixed-height-container be the more suitable name now? - Can this just be within search_engines_list.html, if that's the only place that uses this class?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hcarmona@chromium.org changed reviewers: + dschuyler@chromium.org - scottchen@chromium.org
Scott's OOO, can you PTAL?
https://codereview.chromium.org/2855273002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (left): https://codereview.chromium.org/2855273002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:231: .fixed-height-list { On 2017/05/03 23:01:27, scottchen wrote: > - Would fixed-height-container be the more suitable name now? > - Can this just be within search_engines_list.html, if that's the only place > that uses this class? I'm flexible on the class name, but I agree that it should be moved to the file where it is used it it's only used in one place. Also consider a comment about the "* 6" part of the calc (i.e. why is it there).
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
https://codereview.chromium.org/2855273002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (left): https://codereview.chromium.org/2855273002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:231: .fixed-height-list { On 2017/05/08 20:35:29, dschuyler wrote: > On 2017/05/03 23:01:27, scottchen wrote: > > - Would fixed-height-container be the more suitable name now? > > - Can this just be within search_engines_list.html, if that's the only place > > that uses this class? > > I'm flexible on the class name, but I agree that it should be moved to the file > where it is used it it's only used in one place. > > Also consider a comment about the "* 6" part of the calc (i.e. why is it there). Sorry for forwarding before updating the CL. Moved to search_engines_list.html, added comment, and renamed.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494881962886980,
"parent_rev": "fd1fe22c153c500c60ffd85cb32eb6576e8ea1ad", "commit_rev":
"1af97c4930cb92df4112db82a79ddacd0041379c"}
Message was sent while issue was closed.
Description was changed from ========== Make fixed size scrolling more like other lists. R=scottchen@chromium.org BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Make fixed size scrolling more like other lists. R=scottchen@chromium.org BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2855273002 Cr-Commit-Position: refs/heads/master@{#471968} Committed: https://chromium.googlesource.com/chromium/src/+/1af97c4930cb92df4112db82a79d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1af97c4930cb92df4112db82a79d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
