Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_list.html

Issue 2855273002: Make fixed size scrolling more like other lists. (Closed)
Patch Set: feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/search_engines_page/search_engines_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/search_engines_page/search_engines_list.html
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html b/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
index 04c9a28a3c5f14387a3e180bd82f8d6ffc4e2cf6..94461211dad467be7721a6f103976bd932e31608 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
@@ -33,6 +33,13 @@
border-top: var(--settings-separator-line);
}
+ .fixed-height-container {
+ /* Max items we show before scrolling is 6. Adding a 7th item to the
+ * list will add a scroll bar to the container. */
+ max-height: calc((var(--settings-row-min-height) +
+ var(--settings-separator-height)) * 6);
+ }
+
.icon-placeholder {
width: calc(var(--iron-icon-width) + 2 * 10px);
}
@@ -44,9 +51,10 @@
<div class="url">$i18n{searchEnginesQueryURL}</div>
<div class="icon-placeholder"></div>
</div>
- <div id="container" class="scroll-container">
+ <div id="container"
+ class$="scroll-container [[getHeightClass(scrollTarget)]]"
+ scrollable$="[[isScrollable(scrollTarget)]]">
<iron-list items="[[engines]]" scroll-target="[[scrollTarget]]"
- class$="[[getIronListClass_(scrollTarget)]]"
scroll-offset="[[scrollOffset]]">
<template>
<settings-search-engine-entry engine="[[item]]"
« no previous file with comments | « no previous file | chrome/browser/resources/settings/search_engines_page/search_engines_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698