MD Settings: Eliminate SettingsSubpageBrowsertest.

MD Settings: Eliminate SettingsSubpageBrowsertest.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.
 - Remove settings_subpage_browsertest.js, it was used to benchmark rendering
   of specific subpages, not necessary anymore.

BUG=709442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2855253003
Cr-Commit-Position: refs/heads/master@{#471931}
Committed: https://chromium.googlesource.com/chromium/src/+/2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7

[dpapad, 2017-05-04 17:19:15]

Description was changed from

==========
Eliminate SettingsSubpageBrowsertest, smaller scope.

BUG=
==========

to

==========
Eliminate SettingsSubpageBrowsertest, smaller scope.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-04 17:20:16]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 17:20:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 17:25:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 17:25:07]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[dpapad, 2017-05-04 18:43:47]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 18:44:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 18:59:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 18:59:02]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dpapad, 2017-05-09 23:47:12]

Description was changed from

==========
Eliminate SettingsSubpageBrowsertest, smaller scope.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Eliminate SettingsSubpageBrowsertest, smaller scope.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-09 23:47:49]

Description was changed from

==========
Eliminate SettingsSubpageBrowsertest, smaller scope.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Eliminate SettingsSubpageBrowsertest, smaller scope.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-09 23:49:03]

Description was changed from

==========
Eliminate SettingsSubpageBrowsertest, smaller scope.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Eliminate SettingsSubpageBrowsertest, smaller scope.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.
 - Remove settings_subpage_browsertest.js, it was used to benchmark rendering
   of specific subpages, not necessary anymore.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-09 23:49:21]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 23:50:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-05-09 23:52:04]

Description was changed from

==========
Eliminate SettingsSubpageBrowsertest, smaller scope.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.
 - Remove settings_subpage_browsertest.js, it was used to benchmark rendering
   of specific subpages, not necessary anymore.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settisgs: Eliminate SettingsSubpageBrowsertest.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.
 - Remove settings_subpage_browsertest.js, it was used to benchmark rendering
   of specific subpages, not necessary anymore.

BUG=709442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-10 00:16:16]

Description was changed from

==========
MD Settisgs: Eliminate SettingsSubpageBrowsertest.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.
 - Remove settings_subpage_browsertest.js, it was used to benchmark rendering
   of specific subpages, not necessary anymore.

BUG=709442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Eliminate SettingsSubpageBrowsertest.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.
 - Remove settings_subpage_browsertest.js, it was used to benchmark rendering
   of specific subpages, not necessary anymore.

BUG=709442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-05-10 00:18:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:18:31]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[dpapad, 2017-05-10 00:34:38]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 00:36:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-05-10 01:29:45]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2017-05-10 01:29:46]

This is essentially attempting the same as Steven's
https://codereview.chromium.org/2852433003, except that knowing the complication
created by the original CL, I have reduced the scope (no additional
cleanups/simplifications).

[commit-bot: I haz the power, 2017-05-10 02:39:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:39:17]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[michaelpg, 2017-05-11 07:56:03]

Haven't gotten to this yet and I'm out today and tomorrow -- is stevenjb a
better reviewer since he had the original CL?

[michaelpg, 2017-05-11 07:59:39]

actually this is pretty easy to review. lgtm

[dpapad, 2017-05-15 20:48:22]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-05-15 20:48:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2855253003/#ps100001
(title: "Resolve conflicts.")

[commit-bot: I haz the power, 2017-05-15 20:49:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 22:38:56]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494881302670590,
"parent_rev": "1a2e9429dd31e0929621a54e7728dcfe3a58ddab", "commit_rev":
"2d8b0d7ee334c20a8a91bd27116c1eb40a85e3e7"}

[commit-bot: I haz the power, 2017-05-15 22:39:10]

Description was changed from

==========
MD Settings: Eliminate SettingsSubpageBrowsertest.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.
 - Remove settings_subpage_browsertest.js, it was used to benchmark rendering
   of specific subpages, not necessary anymore.

BUG=709442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Eliminate SettingsSubpageBrowsertest.

 - Remove SettingsPageVisibility behavior, since only basic-page is using it.
 - Remove global var settingsHidePagesByDefaultForTest.
 - Remove settings_subpage_browsertest.js, it was used to benchmark rendering
   of specific subpages, not necessary anymore.

BUG=709442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2855253003
Cr-Commit-Position: refs/heads/master@{#471931}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d8b0d7ee334c20a8a91bd27116c...
==========

[commit-bot: I haz the power, 2017-05-15 22:39:12]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2d8b0d7ee334c20a8a91bd27116c...