Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 2855253003: MD Settings: Eliminate SettingsSubpageBrowsertest. (Closed)
Patch Set: Resolve conflicts. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/basic_page/basic_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/basic_page/basic_page.html
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.html b/chrome/browser/resources/settings/basic_page/basic_page.html
index c4b95c7ed787eb3340439cb3ef99c66f3ef425cf..8283f1f2ee57e2b6263aacc45574094495868ee1 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.html
+++ b/chrome/browser/resources/settings/basic_page/basic_page.html
@@ -7,7 +7,6 @@
<link rel="import" href="../reset_page/reset_profile_banner.html">
<link rel="import" href="../search_page/search_page.html">
<link rel="import" href="../settings_page/main_page_behavior.html">
-<link rel="import" href="../settings_page/settings_page_visibility.html">
<link rel="import" href="../settings_page/settings_section.html">
<link rel="import" href="../settings_page_css.html">
<link rel="import" href="../settings_vars_css.html">
@@ -98,7 +97,7 @@
</div>
</if>
<if expr="chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.internet)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.internet)]]"
restamp>
<settings-section page-title="$i18n{internetPageTitle}"
section="internet">
@@ -106,7 +105,7 @@
</settings-internet-page>
</settings-section>
</template>
- <template is="dom-if" if="[[showPage(pageVisibility.bluetooth)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.bluetooth)]]"
restamp>
<settings-section page-title="$i18n{bluetoothPageTitle}"
section="bluetooth">
@@ -115,13 +114,13 @@
</settings-section>
</template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.people)]]" restamp>
+ <template is="dom-if" if="[[showPage_(pageVisibility.people)]]" restamp>
<settings-section page-title="$i18n{peoplePageTitle}"
section="people">
<settings-people-page prefs="{{prefs}}"></settings-people-page>
</settings-section>
</template>
- <template is="dom-if" if="[[showPage(pageVisibility.appearance)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.appearance)]]"
restamp>
<settings-section page-title="$i18n{appearancePageTitle}"
section="appearance">
@@ -131,14 +130,14 @@
</settings-section>
</template>
<if expr="chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.device)]]" restamp>
+ <template is="dom-if" if="[[showPage_(pageVisibility.device)]]" restamp>
<settings-section page-title="$i18n{devicePageTitle}"
section="device">
<settings-device-page prefs="{{prefs}}"></settings-device-page>
</settings-section>
</template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.search)]]" restamp>
+ <template is="dom-if" if="[[showPage_(pageVisibility.search)]]" restamp>
<settings-section page-title="$i18n{searchPageTitle}"
section="search">
<settings-search-page prefs="{{prefs}}"></settings-search-page>
@@ -156,7 +155,7 @@
</template>
</if>
<if expr="not chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.defaultBrowser)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.defaultBrowser)]]"
restamp>
<settings-section page-title="$i18n{defaultBrowser}"
section="defaultBrowser">
@@ -164,7 +163,7 @@
</settings-section>
</template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.onStartup)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.onStartup)]]"
restamp>
<settings-section page-title="$i18n{onStartup}" section="onStartup">
<settings-on-startup-page prefs="{{prefs}}">
@@ -194,7 +193,7 @@
currentRoute_, inSearchMode, hasExpandedSection_,
advancedToggleExpanded)]]">
<if expr="chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.dateTime)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.dateTime)]]"
restamp>
<settings-section page-title="$i18n{dateTimePageTitle}"
section="dateTime">
@@ -204,7 +203,7 @@
</settings-section>
</template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.privacy)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.privacy)]]"
restamp>
<settings-section page-title="$i18n{privacyPageTitle}"
section="privacy">
@@ -214,7 +213,7 @@
</settings-section>
</template>
<template is="dom-if"
- if="[[showPage(pageVisibility.passwordsAndForms)]]" restamp>
+ if="[[showPage_(pageVisibility.passwordsAndForms)]]" restamp>
<settings-section
page-title="$i18n{passwordsAndAutofillPageTitle}"
section="passwordsAndForms">
@@ -222,7 +221,7 @@
</settings-passwords-and-forms-page>
</settings-section>
</template>
- <template is="dom-if" if="[[showPage(pageVisibility.languages)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.languages)]]"
restamp>
<settings-section page-title="$i18n{languagesPageTitle}"
section="languages">
@@ -230,7 +229,7 @@
</settings-languages-page>
</settings-section>
</template>
- <template is="dom-if" if="[[showPage(pageVisibility.downloads)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.downloads)]]"
restamp>
<settings-section page-title="$i18n{downloadsPageTitle}"
section="downloads">
@@ -239,7 +238,7 @@
</settings-downloads-page>
</settings-section>
</template>
- <template is="dom-if" if="[[showPage(pageVisibility.printing)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.printing)]]"
restamp>
<settings-section page-title="$i18n{printingPageTitle}"
section="printing">
@@ -247,13 +246,13 @@
</settings-printing-page>
</settings-section>
</template>
- <template is="dom-if" if="[[showPage(pageVisibility.a11y)]]" restamp>
+ <template is="dom-if" if="[[showPage_(pageVisibility.a11y)]]" restamp>
<settings-section page-title="$i18n{a11yPageTitle}" section="a11y">
<settings-a11y-page prefs="{{prefs}}"></settings-a11y-page>
</settings-section>
</template>
<if expr="not chromeos">
- <template is="dom-if" if="[[showPage(pageVisibility.system)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.system)]]"
restamp>
<settings-section page-title="$i18n{systemPageTitle}"
section="system">
@@ -261,7 +260,7 @@
</settings-section>
</template>
</if>
- <template is="dom-if" if="[[showPage(pageVisibility.reset)]]"
+ <template is="dom-if" if="[[showPage_(pageVisibility.reset)]]"
restamp>
<settings-section page-title="$i18n{resetPageTitle}"
section="reset">
« no previous file with comments | « no previous file | chrome/browser/resources/settings/basic_page/basic_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698