Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5790)

Unified Diff: chrome/browser/ui/views/payments/payment_request_item_list.h

Issue 2855203002: [Payments] Display the shipping option error alongside the address (Closed)
Patch Set: added tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_item_list.h
diff --git a/chrome/browser/ui/views/payments/payment_request_item_list.h b/chrome/browser/ui/views/payments/payment_request_item_list.h
index b2d360ed2b91eec7c9bed453d070be6b67b81f53..ec54f712ec54d27d24c8d7edf9e66d930ab38bdf 100644
--- a/chrome/browser/ui/views/payments/payment_request_item_list.h
+++ b/chrome/browser/ui/views/payments/payment_request_item_list.h
@@ -76,10 +76,14 @@ class PaymentRequestItemList {
// item's view, such as the credit card icon.
virtual std::unique_ptr<views::View> CreateExtraView();
+ // Whether the item should be disabled (user will not be able to click on
+ // it).
+ virtual bool IsDisabled() = 0;
+
// Returns whether this item is complete/valid and can be selected by the
// user. If this returns false when the user attempts to select this item,
// PerformSelectionFallback will be called instead.
- virtual bool CanBeSelected() const = 0;
+ virtual bool CanBeSelected() = 0;
anthonyvd 2017/05/04 13:07:37 Why remove const?
Mathieu 2017/05/04 13:53:25 It calls IsEnabled, which calls into state(), whic
// Performs the action that replaces selection when CanBeSelected returns
// false. This will usually be to display an editor.

Powered by Google App Engine
This is Rietveld 408576698