Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3495)

Unified Diff: chrome/browser/ui/views/payments/payment_method_view_controller.cc

Issue 2855203002: [Payments] Display the shipping option error alongside the address (Closed)
Patch Set: added tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_method_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/payment_method_view_controller.cc b/chrome/browser/ui/views/payments/payment_method_view_controller.cc
index 2a2aea501d380dfd1ec735d65dbbbb0c4621a2e3..1062b2da5f219209ea92f43a761dc5841ce26eb8 100644
--- a/chrome/browser/ui/views/payments/payment_method_view_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_method_view_controller.cc
@@ -110,7 +110,12 @@ class PaymentMethodListItem : public payments::PaymentRequestItemList::Item {
}
}
- bool CanBeSelected() const override {
+ bool IsDisabled() override {
anthonyvd 2017/05/04 13:07:37 Can this be IsEnabled instead? Affirmative is easi
Mathieu 2017/05/04 13:53:25 Sure thing!
+ // No items are disabled.
+ return false;
+ }
+
+ bool CanBeSelected() override {
// If an instrument can't be selected, PerformSelectionFallback is called,
// where the instrument can be made complete.
return instrument_->IsCompleteForPayment();

Powered by Google App Engine
This is Rietveld 408576698