[Payments] Display the shipping option error alongside the address

chrome/browser/ui/views/payments/payment_request_item_list.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_ITEM_LIST_H_
 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_ITEM_LIST_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 58 matching lines @@
     std::unique_ptr<views::ImageView> CreateCheckmark(bool selected);
 
     // Creates the view that represents this item's content. Typically this will
     // be a label describing the payment method, shipping adress, etc.
     virtual std::unique_ptr<views::View> CreateContentView() = 0;
 
     // Creates the view that should be displayed after the checkmark in the
     // item's view, such as the credit card icon.
     virtual std::unique_ptr<views::View> CreateExtraView();
 
+    // Whether the item should be disabled (user will not be able to click on
+    // it).
+    virtual bool IsDisabled() = 0;
+
     // Returns whether this item is complete/valid and can be selected by the
     // user. If this returns false when the user attempts to select this item,
     // PerformSelectionFallback will be called instead.
-    virtual bool CanBeSelected() const = 0;
+    virtual bool CanBeSelected() = 0;

[anthonyvd, 2017/05/04 13:07:37]

Why remove const?

[Mathieu, 2017/05/04 13:53:25]

It calls IsEnabled, which calls into state(), which can't be const unless we do
some refactoring in PaymentRequestSheetController/PaymentRequestState

 
     // Performs the action that replaces selection when CanBeSelected returns
     // false. This will usually be to display an editor.
     virtual void PerformSelectionFallback() = 0;
 
    private:
     // Creates and returns the view associated with this list item.
     std::unique_ptr<views::View> CreateItemView();
 
     // views::ButtonListener:
@@ skipping 31 matching lines @@
 
   std::vector<std::unique_ptr<Item>> items_;
   Item* selected_item_;
 
   DISALLOW_COPY_AND_ASSIGN(PaymentRequestItemList);
 };
 
 }  // namespace payments
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_ITEM_LIST_H_