MD Settings: hide browsing history-related rows for supervised users

MD Settings: hide browsing history-related rows for supervised users

R=dpapad@chromium.org
BUG=696910
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2855123004
Cr-Commit-Position: refs/heads/master@{#469555}
Committed: https://chromium.googlesource.com/chromium/src/+/a398dcde748d755c995cecbe71af270cd02da03e

[Dan Beam, 2017-05-04 03:28:08]

Description was changed from

==========
MD Settings: hide browsing history-related rows for supervised users

R=dpapad@chromium.org
BUG=696910
==========

to

==========
MD Settings: hide browsing history-related rows for supervised users

R=dpapad@chromium.org
BUG=696910
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-04 03:29:02]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 03:29:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 03:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 03:40:17]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2017-05-04 03:44:06]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 03:44:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 05:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 05:33:38]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-05-04 22:43:02]

https://codereview.chromium.org/2855123004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/privacy_page_test.js (right):

https://codereview.chromium.org/2855123004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/privacy_page_test.js:255: element =
document.createElement('settings-clear-browsing-data-dialog');
If we are going to recreate the element anyway, just for this test() case, how
about the following instead?

1) Revert changes to CBD proxy.
2) In clear_browsing_data_dialog.js
   this.showBrowsingHistoryRows_ = loadTimeData.getBoolean('isSupervised');
3) Use loadTimeData.overrideValues() here, similar to what we do in other
occanions, see
https://cs.chromium.org/search/?q=overrideValues+file:%5Esrc/chrome/test/data...

This would be require less code (no proxy changes), and more aligned with how we
inject values to loadTimeData in other tests.

[Dan Beam, 2017-05-04 23:21:29]

https://codereview.chromium.org/2855123004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/privacy_page_test.js (right):

https://codereview.chromium.org/2855123004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/privacy_page_test.js:255: element =
document.createElement('settings-clear-browsing-data-dialog');
On 2017/05/04 22:43:02, dpapad wrote:
> If we are going to recreate the element anyway, just for this test() case, how
> about the following instead?
> 
> 1) Revert changes to CBD proxy.
> 2) In clear_browsing_data_dialog.js
>    this.showBrowsingHistoryRows_ = loadTimeData.getBoolean('isSupervised');
> 3) Use loadTimeData.overrideValues() here, similar to what we do in other
> occanions, see
>
https://cs.chromium.org/search/?q=overrideValues+file:%5Esrc/chrome/test/data...
> 
> This would be require less code (no proxy changes), and more aligned with how
we
> inject values to loadTimeData in other tests.

Done. (thanks for reminding me about overrideValues! makes everything much
simpler!)

[Dan Beam, 2017-05-04 23:22:15]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 23:23:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-05-04 23:30:51]

LGTM

[Dan Beam, 2017-05-04 23:35:09]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 23:36:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-05-05 00:05:34]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2017-05-05 00:05:38]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:06:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 00:56:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493942738892740,
"parent_rev": "799c3a19b81b7ae194e4740defb95656f6de7034", "commit_rev":
"a398dcde748d755c995cecbe71af270cd02da03e"}

[commit-bot: I haz the power, 2017-05-05 00:56:45]

Description was changed from

==========
MD Settings: hide browsing history-related rows for supervised users

R=dpapad@chromium.org
BUG=696910
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: hide browsing history-related rows for supervised users

R=dpapad@chromium.org
BUG=696910
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2855123004
Cr-Commit-Position: refs/heads/master@{#469555}
Committed:
https://chromium.googlesource.com/chromium/src/+/a398dcde748d755c995cecbe71af...
==========

[commit-bot: I haz the power, 2017-05-05 00:56:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a398dcde748d755c995cecbe71af...