Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

Issue 2855123004: MD Settings: hide browsing history-related rows for supervised users (Closed)
Patch Set: comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
index f26511369b45d4d88f7876f3c062b5b01a6918ab..780f0dadc9e115d5596f66cd33105a86a3c3cebc 100644
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
@@ -111,17 +111,23 @@
menu-options="[[clearFromOptions_]]">
</settings-dropdown-menu>
</div>
+ <!-- Note: whether these checkboxes are checked are ignored if deleting
+ history is disabled (i.e. supervised users, policy), so it's OK to
+ have a hidden checkbox that's also checked (as the C++ accounts for
+ whether a user is allowed to delete history independently). -->
<settings-checkbox id="browsingCheckbox"
pref="{{prefs.browser.clear_data.browsing_history}}"
label="$i18n{clearBrowsingHistory}"
sub-label="[[counters_.browsing_history]]"
- disabled="[[clearingInProgress_]]">
+ disabled="[[clearingInProgress_]]"
+ hidden="[[isSupervised_]]">
</settings-checkbox>
<settings-checkbox id="downloadCheckbox"
pref="{{prefs.browser.clear_data.download_history}}"
label="$i18n{clearDownloadHistory}"
sub-label="[[counters_.download_history]]"
- disabled="[[clearingInProgress_]]">
+ disabled="[[clearingInProgress_]]"
+ hidden="[[isSupervised_]]">
</settings-checkbox>
<settings-checkbox
pref="{{prefs.browser.clear_data.cache}}"
« no previous file with comments | « no previous file | chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698