Small-scale clean ups in test.dart, mainly around test_progress.

Small-scale clean ups in test.dart, mainly around test_progress.

Stuff like:

- Use core lib methods like padLeft() now that they exist.
- Use collection literals (!).
- Use getters where appropriate.
- Make Formatter enum-like since it has no interesting instance state.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/9cd2f83ef75b5c9c64207b716e2d3cb3f228dd0b

[Bob Nystrom, 2017-05-03 00:13:48]

rnystrom@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2017-05-03 08:25:27]

lgtm

[Bob Nystrom, 2017-05-03 23:50:51]

Description was changed from

==========
Small-scale clean ups in test.dart, mainly around test_progress.

Stuff like:

- Use core lib methods like padLeft() now that they exist.
- Use collection literals (!).
- Use getters where appropriate.
- Make Formatter enum-like since it has no interesting instance state.
==========

to

==========
Small-scale clean ups in test.dart, mainly around test_progress.

Stuff like:

- Use core lib methods like padLeft() now that they exist.
- Use collection literals (!).
- Use getters where appropriate.
- Make Formatter enum-like since it has no interesting instance state.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9cd2f83ef75b5c9c64207b716e2d3cb3f228dd0b
==========

[Bob Nystrom, 2017-05-03 23:50:53]

Committed patchset #1 (id:1) manually as
9cd2f83ef75b5c9c64207b716e2d3cb3f228dd0b (presubmit successful).

[ahe, 2017-05-09 07:30:00]

https://codereview.chromium.org/2855073002/diff/1/tools/testing/dart/test_pro...
File tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/2855073002/diff/1/tools/testing/dart/test_pro...
tools/testing/dart/test_progress.dart:592: formatter.failed('FAILED:
${test.configurationString}${test.displayName}')
There's a space missing between ${test.configurationString} and
${test.displayName}

[Bob Nystrom, 2017-05-09 17:32:36]

https://codereview.chromium.org/2855073002/diff/1/tools/testing/dart/test_pro...
File tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/2855073002/diff/1/tools/testing/dart/test_pro...
tools/testing/dart/test_progress.dart:592: formatter.failed('FAILED:
${test.configurationString}${test.displayName}')
On 2017/05/09 07:30:00, ahe wrote:
> There's a space missing between ${test.configurationString} and
> ${test.displayName}

Good catch, thanks!

https://codereview.chromium.org/2866273002/