Small-scale clean ups in test.dart, mainly around test_progress.

tools/testing/dart/test_configurations.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_configurations;
 
 import "dart:async";
 import 'dart:convert';
 import 'dart:io';
 import "dart:math" as math;
@@ skipping 66 matching lines @@
   Browser.resetBrowserConfiguration = firstConf['reset_browser_configuration'];
 
   if (recordingPath != null && recordingOutputPath != null) {
     print("Fatal: Can't have the '--record_to_file' and '--replay_from_file'"
         "at the same time. Exiting ...");
     exit(1);
   }
 
   if (!firstConf['append_logs']) {
     var files = [
-      new File(TestUtils.flakyFileName()),
-      new File(TestUtils.testOutcomeFileName())
+      new File(TestUtils.flakyFileName),
+      new File(TestUtils.testOutcomeFileName)
     ];
     for (var file in files) {
       if (file.existsSync()) {
         file.deleteSync();
       }
     }
   }
 
   DebugLogger.init(
-      firstConf['write_debug_log'] ? TestUtils.debugLogfile() : null,
+      firstConf['write_debug_log'] ? TestUtils.debugLogFilePath : null,
       append: firstConf['append_logs']);
 
   // Print the configurations being run by this execution of
   // test.dart. However, don't do it if the silent progress indicator
   // is used. This is only needed because of the junit tests.
   if (progressIndicator != 'silent') {
     List output_words = configurations.length > 1
         ? ['Test configurations:']
         : ['Test configuration:'];
     for (Map conf in configurations) {
@@ skipping 35 matching lines @@
           conf['runtime'],
           null,
           conf['package_root'],
           conf['packages']);
       serverFutures.add(servers.startServers(conf['local_ip'],
           port: conf['test_server_port'],
           crossOriginPort: conf['test_server_cross_origin_port']));
       conf['_servers_'] = servers;
       if (verbose) {
         serverFutures.last.then((_) {
-          var commandline = servers.httpServerCommandline();
+          var commandline = servers.httpServerCommandLine();
           print('Started HttpServers: $commandline');
         });
       }
     }
 
     if (conf['runtime'].startsWith('ie')) {
       // NOTE: We've experienced random timeouts of tests on ie9/ie10. The
       // underlying issue has not been determined yet. Our current hypothesis
       // is that windows does not handle the IE processes independently.
       // If we have more than one browser and kill a browser we are seeing
@@ skipping 52 matching lines @@
   void allTestsFinished() {
     for (var conf in configurations) {
       if (conf.containsKey('_servers_')) {
         conf['_servers_'].stopServers();
       }
     }
     DebugLogger.close();
     TestUtils.deleteTempSnapshotDirectory(configurations[0]);
   }
 
-  var eventListener = [];
+  var eventListener = <EventListener>[];
 
   // We don't print progress if we list tests.
   if (progressIndicator != 'silent' && !listTests) {
     var printFailures = true;
-    var formatter = new Formatter();
+    var formatter = Formatter.normal;
     if (progressIndicator == 'color') {
       progressIndicator = 'compact';
-      formatter = new ColorFormatter();
+      formatter = Formatter.color;
     }
     if (progressIndicator == 'diff') {
       progressIndicator = 'compact';
-      formatter = new ColorFormatter();
+      formatter = Formatter.color;
       printFailures = false;
       eventListener.add(new StatusFileUpdatePrinter());
     }
     eventListener.add(new SummaryPrinter());
     eventListener.add(new FlakyLogWriter());
     if (printFailures) {
       // The buildbot has it's own failure summary since it needs to wrap it
       // into '@@@'-annotated sections.
       var printFailureSummary = progressIndicator != 'buildbot';
       eventListener.add(new TestFailurePrinter(printFailureSummary, formatter));
     }
     eventListener.add(
-        progressIndicatorFromName(progressIndicator, startTime, formatter));
+        ProgressIndicator.fromName(progressIndicator, startTime, formatter));
     if (printTiming) {
       eventListener.add(new TimingPrinter(startTime));
     }
     eventListener.add(new SkippedCompilationsPrinter());
   }
   if (firstConf['write_test_outcome_log']) {
     eventListener.add(new TestOutcomeLogWriter());
   }
   if (firstConf['copy_coredumps']) {
     eventListener.add(new UnexpectedCrashLogger());
@@ skipping 44 matching lines @@
       maxBrowserProcesses,
       startTime,
       testSuites,
       eventListener,
       allTestsFinished,
       verbose,
       recordingPath,
       recordingOutputPath,
       adbDevicePool);
 }