Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 2855073002: Small-scale clean ups in test.dart, mainly around test_progress. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 8b863a390fc34d49c056a9359c6ac9185542f6c7..397db586465241978ba2d2d1089fb35ef55bf55e 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1969,24 +1969,18 @@ class TestUtils {
}
}
- static Path debugLogfile() {
- return new Path(".debug.log");
- }
-
- static String flakyFileName() {
- // If a flaky test did fail, infos about it (i.e. test name, stdin, stdout)
- // will be written to this file. This is useful for the debugging of
- // flaky tests.
- // When running on a built bot, the file can be made visible in the
- // waterfall UI.
- return ".flaky.log";
- }
-
- static String testOutcomeFileName() {
- // If test.py was invoked with '--write-test-outcome-log it will write
- // test outcomes to this file.
- return ".test-outcome.log";
- }
+ static final debugLogFilePath = new Path(".debug.log");
+
+ /// If a flaky test did fail, infos about it (i.e. test name, stdin, stdout)
+ /// will be written to this file.
+ ///
+ /// This is useful for debugging flaky tests. When running on a buildbot, the
+ /// file can be made visible in the waterfall UI.
+ static const flakyFileName = ".flaky.log";
+
+ /// If test.py was invoked with '--write-test-outcome-log it will write
+ /// test outcomes to this file.
+ static const testOutcomeFileName = ".test-outcome.log";
static void ensureExists(String filename, Map configuration) {
if (!configuration['list'] && !existsCache.doesFileExist(filename)) {
« tools/testing/dart/test_progress.dart ('K') | « tools/testing/dart/test_progress.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698