Move disable_display_vsync out of RendererSettings

Move disable_display_vsync out of RendererSettings

disable_display_vsync is read by GpuProcessTransportFactory and
TestCompositorFrameSink only. It is not used by Renderers so it should not be
in RendererSettings.

GpuProcessTransportFactory gets disable_display_vsync from command line switch
and stores it in disable_display_vsync_.

LayerTreeTest and its subclasses pass disable_display_vsync in to
TestCompositorFrameSink via its constructor. LayerTreeHostPerfTest overrides
LayerTreeTest::CreateCompositorFrameSink to set disable_display_vsync to true
to preserve behaviors.

BUG=717959
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2854953006
Cr-Commit-Position: refs/heads/master@{#469439}
Committed: https://chromium.googlesource.com/chromium/src/+/60f32e2dc84431ea6131e760fd5480b415aff5e8

[Alex Z., 2017-05-03 21:50:25]

Description was changed from

==========
Move disable_display_vsync out of RendererSettings

disable_display_vsync is read by GpuProcessTransportFactory and
TestCompositorFrameSink only. It is not used by Renderers so it should not be
in RendererSettings.

GpuProcessTransportFactory gets disable_display_vsync from command line switch
and stores it in disable_display_vsync_.

LayerTreeTest and its subclasses pass disable_display_vsync in to
TestCompositorFrameSink via its constructor. LayerTreeHostPerfTest overrides
LayerTreeTest::CreateCompositorFrameSink to set disable_display_vsync to true
to preserve behaviors.

BUG=717959
==========

to

==========
Move disable_display_vsync out of RendererSettings

disable_display_vsync is read by GpuProcessTransportFactory and
TestCompositorFrameSink only. It is not used by Renderers so it should not be
in RendererSettings.

GpuProcessTransportFactory gets disable_display_vsync from command line switch
and stores it in disable_display_vsync_.

LayerTreeTest and its subclasses pass disable_display_vsync in to
TestCompositorFrameSink via its constructor. LayerTreeHostPerfTest overrides
LayerTreeTest::CreateCompositorFrameSink to set disable_display_vsync to true
to preserve behaviors.

BUG=717959
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Alex Z., 2017-05-03 21:50:32]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 21:51:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-05-03 21:51:10]

staraz@chromium.org changed reviewers:
+ danakj@chromium.org

[Alex Z., 2017-05-03 21:51:11]

danakj@: PTAL.

[commit-bot: I haz the power, 2017-05-03 22:03:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 22:03:53]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Alex Z., 2017-05-03 22:12:52]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 22:13:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 23:18:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 23:18:40]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-05-04 15:36:36]

LGTM

https://codereview.chromium.org/2854953006/diff/20001/cc/test/layer_tree_pixe...
File cc/test/layer_tree_pixel_test.cc (right):

https://codereview.chromium.org/2854953006/diff/20001/cc/test/layer_tree_pixe...
cc/test/layer_tree_pixel_test.cc:45: constexpr bool kDisableDisplayVsync =
false;
can you put this beside where its used, like synchronous_composite is. also for
local variables, i think i prefer not kFooBar names, just use foo_bar.

https://codereview.chromium.org/2854953006/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2854953006/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:8758: constexpr bool
kSynchronousComposite = true;
can you put these beside where they are used

https://codereview.chromium.org/2854953006/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_perftest.cc (right):

https://codereview.chromium.org/2854953006/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_perftest.cc:49: // LayerTreeTests give the Display's
BeginFrameSource directly to the
I don't think this comment makes sense anymore, now that we have
BeginFrameScheduling.

https://codereview.chromium.org/2854953006/diff/20001/content/browser/composi...
File content/browser/compositor/gpu_process_transport_factory.cc (right):

https://codereview.chromium.org/2854953006/diff/20001/content/browser/composi...
content/browser/compositor/gpu_process_transport_factory.cc:204: std::string
display_vsyn_string =
vsync

https://codereview.chromium.org/2854953006/diff/20001/content/test/layouttest...
File content/test/layouttest_support.cc (right):

https://codereview.chromium.org/2854953006/diff/20001/content/test/layouttest...
content/test/layouttest_support.cc:353: synchronous_composite, false);
/* disable_display_vsync */ or use a local var

[Alex Z., 2017-05-04 18:41:29]

Description was changed from

==========
Move disable_display_vsync out of RendererSettings

disable_display_vsync is read by GpuProcessTransportFactory and
TestCompositorFrameSink only. It is not used by Renderers so it should not be
in RendererSettings.

GpuProcessTransportFactory gets disable_display_vsync from command line switch
and stores it in disable_display_vsync_.

LayerTreeTest and its subclasses pass disable_display_vsync in to
TestCompositorFrameSink via its constructor. LayerTreeHostPerfTest overrides
LayerTreeTest::CreateCompositorFrameSink to set disable_display_vsync to true
to preserve behaviors.

BUG=717959
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move disable_display_vsync out of RendererSettings

disable_display_vsync is read by GpuProcessTransportFactory and
TestCompositorFrameSink only. It is not used by Renderers so it should not be
in RendererSettings.

GpuProcessTransportFactory gets disable_display_vsync from command line switch
and stores it in disable_display_vsync_.

LayerTreeTest and its subclasses pass disable_display_vsync in to
TestCompositorFrameSink via its constructor. LayerTreeHostPerfTest overrides
LayerTreeTest::CreateCompositorFrameSink to set disable_display_vsync to true
to preserve behaviors.

BUG=717959
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=piman@chromium.org
==========

[Alex Z., 2017-05-04 18:41:55]

staraz@chromium.org changed reviewers:
+ piman@chromium.org

[Alex Z., 2017-05-04 18:41:56]

piman@: Please review changes in content.

https://codereview.chromium.org/2854953006/diff/20001/cc/test/layer_tree_pixe...
File cc/test/layer_tree_pixel_test.cc (right):

https://codereview.chromium.org/2854953006/diff/20001/cc/test/layer_tree_pixe...
cc/test/layer_tree_pixel_test.cc:45: constexpr bool kDisableDisplayVsync =
false;
On 2017/05/04 15:36:35, danakj wrote:
> can you put this beside where its used, like synchronous_composite is. also
for
> local variables, i think i prefer not kFooBar names, just use foo_bar.

Done.

https://codereview.chromium.org/2854953006/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2854953006/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:8758: constexpr bool
kSynchronousComposite = true;
On 2017/05/04 15:36:35, danakj wrote:
> can you put these beside where they are used

Done.

https://codereview.chromium.org/2854953006/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_perftest.cc (right):

https://codereview.chromium.org/2854953006/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_perftest.cc:49: // LayerTreeTests give the Display's
BeginFrameSource directly to the
On 2017/05/04 15:36:35, danakj wrote:
> I don't think this comment makes sense anymore, now that we have
> BeginFrameScheduling.

Done.

https://codereview.chromium.org/2854953006/diff/20001/content/browser/composi...
File content/browser/compositor/gpu_process_transport_factory.cc (right):

https://codereview.chromium.org/2854953006/diff/20001/content/browser/composi...
content/browser/compositor/gpu_process_transport_factory.cc:204: std::string
display_vsyn_string =
On 2017/05/04 15:36:36, danakj wrote:
> vsync

Done.

https://codereview.chromium.org/2854953006/diff/20001/content/test/layouttest...
File content/test/layouttest_support.cc (right):

https://codereview.chromium.org/2854953006/diff/20001/content/test/layouttest...
content/test/layouttest_support.cc:353: synchronous_composite, false);
On 2017/05/04 15:36:36, danakj wrote:
> /* disable_display_vsync */ or use a local var

Done.

[Alex Z., 2017-05-04 18:42:05]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-05-04 18:42:05]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2854953006/#ps40001
(title: "Address Comments")

[commit-bot: I haz the power, 2017-05-04 18:42:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 18:54:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 18:54:26]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alex Z., 2017-05-04 18:57:02]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-05-04 18:57:02]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2854953006/#ps60001
(title: "Correct typo")

[commit-bot: I haz the power, 2017-05-04 18:57:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 20:04:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493924222351420,
"parent_rev": "309a96117edbe53789c764bfcff76c13b0e88b52", "commit_rev":
"60f32e2dc84431ea6131e760fd5480b415aff5e8"}

[commit-bot: I haz the power, 2017-05-04 20:05:11]

Description was changed from

==========
Move disable_display_vsync out of RendererSettings

disable_display_vsync is read by GpuProcessTransportFactory and
TestCompositorFrameSink only. It is not used by Renderers so it should not be
in RendererSettings.

GpuProcessTransportFactory gets disable_display_vsync from command line switch
and stores it in disable_display_vsync_.

LayerTreeTest and its subclasses pass disable_display_vsync in to
TestCompositorFrameSink via its constructor. LayerTreeHostPerfTest overrides
LayerTreeTest::CreateCompositorFrameSink to set disable_display_vsync to true
to preserve behaviors.

BUG=717959
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=piman@chromium.org
==========

to

==========
Move disable_display_vsync out of RendererSettings

disable_display_vsync is read by GpuProcessTransportFactory and
TestCompositorFrameSink only. It is not used by Renderers so it should not be
in RendererSettings.

GpuProcessTransportFactory gets disable_display_vsync from command line switch
and stores it in disable_display_vsync_.

LayerTreeTest and its subclasses pass disable_display_vsync in to
TestCompositorFrameSink via its constructor. LayerTreeHostPerfTest overrides
LayerTreeTest::CreateCompositorFrameSink to set disable_display_vsync to true
to preserve behaviors.

BUG=717959
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2854953006
Cr-Commit-Position: refs/heads/master@{#469439}
Committed:
https://chromium.googlesource.com/chromium/src/+/60f32e2dc84431ea6131e760fd54...
==========

[commit-bot: I haz the power, 2017-05-04 20:05:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/60f32e2dc84431ea6131e760fd54...