Adding an Android about:flags feature for offline previews

Adding and Android about:flags feature for offline previews

This adds a command line and about:flags feature for offline previews on
Android.

BUG=714759
Review-Url: https://codereview.chromium.org/2854893003
Cr-Commit-Position: refs/heads/master@{#469702}
Committed: https://chromium.googlesource.com/chromium/src/+/28839dee4819459127f8036e99f32d917601ee50

[RyanSturm, 2017-05-02 21:50:16]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 21:50:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-05-02 22:34:46]

ryansturm@chromium.org changed reviewers:
+ tbansal@chromium.org

[RyanSturm, 2017-05-02 22:34:47]

tbansal: PTAL

[RyanSturm, 2017-05-02 22:35:15]

Description was changed from

==========
Adding and Android about:flags feature for offline previews

This adds a command line and about:flags feature for offline previews on
Android.

BUG=714759
==========

to

==========
Adding and Android about:flags feature for offline previews

This adds a command line and about:flags feature for offline previews on
Android.

BUG=714759
==========

[commit-bot: I haz the power, 2017-05-02 22:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 22:57:15]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-05-03 17:35:19]

https://codereview.chromium.org/2854893003/diff/1/chrome/browser/flag_descrip...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2854893003/diff/1/chrome/browser/flag_descrip...
chrome/browser/flag_descriptions.cc:1211: "Enable showing offline page previews
on poor networks.";
s/poor/slow/

https://codereview.chromium.org/2854893003/diff/1/components/previews/core/pr...
File components/previews/core/previews_experiments.cc (right):

https://codereview.chromium.org/2854893003/diff/1/components/previews/core/pr...
components/previews/core/previews_experiments.cc:142:
(IsIncludedInClientSidePreviewsExperimentsFieldTrial() &&
IIUC, this is not required anymore. Can we delete this?

[RyanSturm, 2017-05-03 21:26:19]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[RyanSturm, 2017-05-03 21:26:25]

https://codereview.chromium.org/2854893003/diff/1/chrome/browser/flag_descrip...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2854893003/diff/1/chrome/browser/flag_descrip...
chrome/browser/flag_descriptions.cc:1211: "Enable showing offline page previews
on poor networks.";
On 2017/05/03 17:35:19, tbansal1 wrote:
> s/poor/slow/

Done.

https://codereview.chromium.org/2854893003/diff/1/components/previews/core/pr...
File components/previews/core/previews_experiments.cc (right):

https://codereview.chromium.org/2854893003/diff/1/components/previews/core/pr...
components/previews/core/previews_experiments.cc:142:
(IsIncludedInClientSidePreviewsExperimentsFieldTrial() &&
On 2017/05/03 17:35:19, tbansal1 wrote:
> IIUC, this is not required anymore. Can we delete this?

Not sure what you mean. I have to adjust the finch trials to have a seperate
case for "OfflinePreviews:enabled" and "OfflinePreviews:disabled"

[commit-bot: I haz the power, 2017-05-03 21:26:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 22:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 22:33:25]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-05-03 22:54:04]

https://codereview.chromium.org/2854893003/diff/1/components/previews/core/pr...
File components/previews/core/previews_experiments.cc (right):

https://codereview.chromium.org/2854893003/diff/1/components/previews/core/pr...
components/previews/core/previews_experiments.cc:142:
(IsIncludedInClientSidePreviewsExperimentsFieldTrial() &&
On 2017/05/03 21:26:25, Ryan Sturm wrote:
> On 2017/05/03 17:35:19, tbansal1 wrote:
> > IIUC, this is not required anymore. Can we delete this?
> 
> Not sure what you mean. I have to adjust the finch trials to have a seperate
> case for "OfflinePreviews:enabled" and "OfflinePreviews:disabled"

Got it. In that case, should
IsIncludedInClientSidePreviewsExperimentsFieldTrial() also be returning true
when OfflinePreviews is enabled using AboutFlags. or, just make it private?

The comment for that method says:
// Returns true if any client-side previews experiment is active.

[RyanSturm, 2017-05-03 23:00:30]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 23:01:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-05-03 23:01:38]

On 2017/05/03 22:54:04, tbansal1 wrote:
>
https://codereview.chromium.org/2854893003/diff/1/components/previews/core/pr...
> File components/previews/core/previews_experiments.cc (right):
> 
>
https://codereview.chromium.org/2854893003/diff/1/components/previews/core/pr...
> components/previews/core/previews_experiments.cc:142:
> (IsIncludedInClientSidePreviewsExperimentsFieldTrial() &&
> On 2017/05/03 21:26:25, Ryan Sturm wrote:
> > On 2017/05/03 17:35:19, tbansal1 wrote:
> > > IIUC, this is not required anymore. Can we delete this?
> > 
> > Not sure what you mean. I have to adjust the finch trials to have a seperate
> > case for "OfflinePreviews:enabled" and "OfflinePreviews:disabled"
> 
> Got it. In that case, should
> IsIncludedInClientSidePreviewsExperimentsFieldTrial() also be returning true
> when OfflinePreviews is enabled using AboutFlags. or, just make it private?
> 
> The comment for that method says:
> // Returns true if any client-side previews experiment is active.

Done.

[tbansal1, 2017-05-03 23:09:49]

lgtm

[RyanSturm, 2017-05-03 23:23:20]

ryansturm@chromium.org changed reviewers:
+ holte@chromium.org

[RyanSturm, 2017-05-03 23:23:21]

holte: PTAL @ histograms.xml

[commit-bot: I haz the power, 2017-05-04 00:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 00:47:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Steven Holte, 2017-05-04 17:49:04]

lgtm but you may need to rebase it to enums.xml

[RyanSturm, 2017-05-05 15:16:17]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2017-05-05 15:16:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 15:20:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 15:20:58]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[RyanSturm, 2017-05-05 15:32:43]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 15:33:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 16:45:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 16:45:21]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-05-05 17:23:49]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2017-05-05 17:23:50]

The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org,
tbansal@chromium.org
Link to the patchset: https://codereview.chromium.org/2854893003/#ps60001
(title: "rebase on enums.xml")

[commit-bot: I haz the power, 2017-05-05 17:24:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 17:34:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494005029547410,
"parent_rev": "491f74bcbb9779eef3c0a8bc117562343dd81923", "commit_rev":
"28839dee4819459127f8036e99f32d917601ee50"}

[commit-bot: I haz the power, 2017-05-05 17:34:38]

Description was changed from

==========
Adding and Android about:flags feature for offline previews

This adds a command line and about:flags feature for offline previews on
Android.

BUG=714759
==========

to

==========
Adding and Android about:flags feature for offline previews

This adds a command line and about:flags feature for offline previews on
Android.

BUG=714759

Review-Url: https://codereview.chromium.org/2854893003
Cr-Commit-Position: refs/heads/master@{#469702}
Committed:
https://chromium.googlesource.com/chromium/src/+/28839dee4819459127f8036e99f3...
==========

[commit-bot: I haz the power, 2017-05-05 17:34:39]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/28839dee4819459127f8036e99f3...