Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2854893003: Adding an Android about:flags feature for offline previews (Closed)

Created:
3 years, 7 months ago by RyanSturm
Modified:
3 years, 7 months ago
Reviewers:
Steven Holte, tbansal1
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding and Android about:flags feature for offline previews This adds a command line and about:flags feature for offline previews on Android. BUG=714759 Review-Url: https://codereview.chromium.org/2854893003 Cr-Commit-Position: refs/heads/master@{#469702} Committed: https://chromium.googlesource.com/chromium/src/+/28839dee4819459127f8036e99f32d917601ee50

Patch Set 1 #

Total comments: 5

Patch Set 2 : tbansal comment #

Patch Set 3 : tbansal comment #

Patch Set 4 : rebase on enums.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -18 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M components/previews/core/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/previews/core/previews_experiments.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M components/previews/core/previews_experiments.cc View 1 2 4 chunks +16 lines, -13 lines 0 comments Download
M components/previews/core/previews_experiments_unittest.cc View 1 2 3 chunks +18 lines, -2 lines 0 comments Download
A components/previews/core/previews_features.h View 1 chunk +18 lines, -0 lines 0 comments Download
A components/previews/core/previews_features.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (25 generated)
RyanSturm
tbansal: PTAL
3 years, 7 months ago (2017-05-02 22:34:47 UTC) #4
tbansal1
https://codereview.chromium.org/2854893003/diff/1/chrome/browser/flag_descriptions.cc File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2854893003/diff/1/chrome/browser/flag_descriptions.cc#newcode1211 chrome/browser/flag_descriptions.cc:1211: "Enable showing offline page previews on poor networks."; s/poor/slow/ ...
3 years, 7 months ago (2017-05-03 17:35:19 UTC) #8
RyanSturm
https://codereview.chromium.org/2854893003/diff/1/chrome/browser/flag_descriptions.cc File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2854893003/diff/1/chrome/browser/flag_descriptions.cc#newcode1211 chrome/browser/flag_descriptions.cc:1211: "Enable showing offline page previews on poor networks."; On ...
3 years, 7 months ago (2017-05-03 21:26:25 UTC) #10
tbansal1
https://codereview.chromium.org/2854893003/diff/1/components/previews/core/previews_experiments.cc File components/previews/core/previews_experiments.cc (right): https://codereview.chromium.org/2854893003/diff/1/components/previews/core/previews_experiments.cc#newcode142 components/previews/core/previews_experiments.cc:142: (IsIncludedInClientSidePreviewsExperimentsFieldTrial() && On 2017/05/03 21:26:25, Ryan Sturm wrote: > ...
3 years, 7 months ago (2017-05-03 22:54:04 UTC) #14
RyanSturm
On 2017/05/03 22:54:04, tbansal1 wrote: > https://codereview.chromium.org/2854893003/diff/1/components/previews/core/previews_experiments.cc > File components/previews/core/previews_experiments.cc (right): > > https://codereview.chromium.org/2854893003/diff/1/components/previews/core/previews_experiments.cc#newcode142 > ...
3 years, 7 months ago (2017-05-03 23:01:38 UTC) #17
tbansal1
lgtm
3 years, 7 months ago (2017-05-03 23:09:49 UTC) #18
RyanSturm
holte: PTAL @ histograms.xml
3 years, 7 months ago (2017-05-03 23:23:21 UTC) #20
Steven Holte
lgtm but you may need to rebase it to enums.xml
3 years, 7 months ago (2017-05-04 17:49:04 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854893003/40001
3 years, 7 months ago (2017-05-05 15:16:48 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/361483) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-05 15:20:58 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854893003/60001
3 years, 7 months ago (2017-05-05 17:24:27 UTC) #34
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 17:34:39 UTC) #37
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/28839dee4819459127f8036e99f3...

Powered by Google App Engine
This is Rietveld 408576698