Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2854893003: Adding an Android about:flags feature for offline previews (Closed)
Patch Set: rebase on enums.xml Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 #include "components/flags_ui/flags_storage.h" 50 #include "components/flags_ui/flags_storage.h"
51 #include "components/flags_ui/flags_ui_switches.h" 51 #include "components/flags_ui/flags_ui_switches.h"
52 #include "components/nacl/common/nacl_switches.h" 52 #include "components/nacl/common/nacl_switches.h"
53 #include "components/ntp_snippets/features.h" 53 #include "components/ntp_snippets/features.h"
54 #include "components/ntp_snippets/ntp_snippets_constants.h" 54 #include "components/ntp_snippets/ntp_snippets_constants.h"
55 #include "components/ntp_tiles/switches.h" 55 #include "components/ntp_tiles/switches.h"
56 #include "components/offline_pages/core/offline_page_feature.h" 56 #include "components/offline_pages/core/offline_page_feature.h"
57 #include "components/omnibox/browser/omnibox_field_trial.h" 57 #include "components/omnibox/browser/omnibox_field_trial.h"
58 #include "components/omnibox/browser/omnibox_switches.h" 58 #include "components/omnibox/browser/omnibox_switches.h"
59 #include "components/password_manager/core/common/password_manager_features.h" 59 #include "components/password_manager/core/common/password_manager_features.h"
60 #include "components/previews/core/previews_features.h"
60 #include "components/proximity_auth/switches.h" 61 #include "components/proximity_auth/switches.h"
61 #include "components/security_state/core/security_state.h" 62 #include "components/security_state/core/security_state.h"
62 #include "components/security_state/core/switches.h" 63 #include "components/security_state/core/switches.h"
63 #include "components/signin/core/common/signin_switches.h" 64 #include "components/signin/core/common/signin_switches.h"
64 #include "components/spellcheck/common/spellcheck_features.h" 65 #include "components/spellcheck/common/spellcheck_features.h"
65 #include "components/spellcheck/common/spellcheck_switches.h" 66 #include "components/spellcheck/common/spellcheck_switches.h"
66 #include "components/spellcheck/spellcheck_build_features.h" 67 #include "components/spellcheck/spellcheck_build_features.h"
67 #include "components/ssl_config/ssl_config_switches.h" 68 #include "components/ssl_config/ssl_config_switches.h"
68 #include "components/strings/grit/components_strings.h" 69 #include "components/strings/grit/components_strings.h"
69 #include "components/suggestions/features.h" 70 #include "components/suggestions/features.h"
(...skipping 1795 matching lines...) Expand 10 before | Expand all | Expand 10 after
1865 FEATURE_WITH_PARAMS_VALUE_TYPE( 1866 FEATURE_WITH_PARAMS_VALUE_TYPE(
1866 data_reduction_proxy::features::kDataReductionMainMenu, 1867 data_reduction_proxy::features::kDataReductionMainMenu,
1867 kDataReductionMainMenuFeatureVariations, 1868 kDataReductionMainMenuFeatureVariations,
1868 "DataReductionProxyMainMenu")}, 1869 "DataReductionProxyMainMenu")},
1869 {"enable-data-reduction-proxy-site-breakdown", 1870 {"enable-data-reduction-proxy-site-breakdown",
1870 flag_descriptions::kEnableDataReductionProxySiteBreakdownName, 1871 flag_descriptions::kEnableDataReductionProxySiteBreakdownName,
1871 flag_descriptions::kEnableDataReductionProxySiteBreakdownDescription, 1872 flag_descriptions::kEnableDataReductionProxySiteBreakdownDescription,
1872 kOsAndroid, 1873 kOsAndroid,
1873 FEATURE_VALUE_TYPE( 1874 FEATURE_VALUE_TYPE(
1874 data_reduction_proxy::features::kDataReductionSiteBreakdown)}, 1875 data_reduction_proxy::features::kDataReductionSiteBreakdown)},
1876 {"enable-offline-previews", flag_descriptions::kEnableOfflinePreviewsName,
1877 flag_descriptions::kEnableOfflinePreviewsDescription, kOsAndroid,
1878 FEATURE_VALUE_TYPE(previews::features::kOfflinePreviews)},
1875 #endif // OS_ANDROID 1879 #endif // OS_ANDROID
1876 {"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhost, 1880 {"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhost,
1877 flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll, 1881 flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll,
1878 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)}, 1882 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)},
1879 {"enable-add-to-shelf", flag_descriptions::kAddToShelfName, 1883 {"enable-add-to-shelf", flag_descriptions::kAddToShelfName,
1880 flag_descriptions::kAddToShelfDescription, kOsDesktop, 1884 flag_descriptions::kAddToShelfDescription, kOsDesktop,
1881 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf, 1885 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf,
1882 switches::kDisableAddToShelf)}, 1886 switches::kDisableAddToShelf)},
1883 {"bypass-app-banner-engagement-checks", 1887 {"bypass-app-banner-engagement-checks",
1884 flag_descriptions::kBypassAppBannerEngagementChecksName, 1888 flag_descriptions::kBypassAppBannerEngagementChecksName,
(...skipping 1173 matching lines...) Expand 10 before | Expand all | Expand 10 after
3058 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3062 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3059 3063
3060 const FeatureEntry* GetFeatureEntries(size_t* count) { 3064 const FeatureEntry* GetFeatureEntries(size_t* count) {
3061 *count = arraysize(kFeatureEntries); 3065 *count = arraysize(kFeatureEntries);
3062 return kFeatureEntries; 3066 return kFeatureEntries;
3063 } 3067 }
3064 3068
3065 } // namespace testing 3069 } // namespace testing
3066 3070
3067 } // namespace about_flags 3071 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698