Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2854883003: Revert of Removes Native App Launcher functionality. (Closed)

Created:
3 years, 7 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Removes Native App Launcher functionality. (patchset #4 id:60001 of https://codereview.chromium.org/2821453003/ ) Reason for revert: Nothing's broken, but will reland with an experimental flag. Original issue's description: > Removes Native App Launcher functionality. > > This is the first step of deprecating Native App Launcher. This step > removes the functionality from Chrome so testing can start. > > There will be lots of dead code and unused classes/methods left after > this step and they will be pruned in subsequent CLs. > > BUG=711511 > TEST=Tools > Settings > Google Apps should not be there. Visits to Maps or YouTube sites will not show infobar. Tapping on Maps or YouTube links may still launch Maps and YouTube app because of Universal Links. > > Review-Url: https://codereview.chromium.org/2821453003 > Cr-Commit-Position: refs/heads/master@{#468374} > Committed: https://chromium.googlesource.com/chromium/src/+/b9c3c20ba9a2a3c05b6d0f976e4a2d71c8a74fa6 TBR=rohitrao@chromium.org,eugenebut@chromium.org,marq@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=711511 Review-Url: https://codereview.chromium.org/2854883003 Cr-Commit-Position: refs/heads/master@{#468805} Committed: https://chromium.googlesource.com/chromium/src/+/333f8780006c4409f44664bdc7d4637bfe636c35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -4 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 8 chunks +48 lines, -4 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 chunk +143 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_collection_view_controller.mm View 4 chunks +15 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_egtest.mm View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pkl (ping after 24h if needed)
Created Revert of Removes Native App Launcher functionality.
3 years, 7 months ago (2017-05-02 22:39:39 UTC) #1
rohitrao (ping after 24h)
LGTM Looks like it's chosen to run itself through the CQ again, which is good.
3 years, 7 months ago (2017-05-02 22:41:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854883003/1
3 years, 7 months ago (2017-05-02 22:42:01 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 22:53:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/333f8780006c4409f44664bdc7d4...

Powered by Google App Engine
This is Rietveld 408576698