Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2821453003: Removes Native App Launcher functionality. (Closed)

Created:
3 years, 8 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes Native App Launcher functionality. This is the first step of deprecating Native App Launcher. This step removes the functionality from Chrome so testing can start. There will be lots of dead code and unused classes/methods left after this step and they will be pruned in subsequent CLs. BUG=711511 TEST=Tools > Settings > Google Apps should not be there. Visits to Maps or YouTube sites will not show infobar. Tapping on Maps or YouTube links may still launch Maps and YouTube app because of Universal Links. Review-Url: https://codereview.chromium.org/2821453003 Cr-Commit-Position: refs/heads/master@{#468374} Committed: https://chromium.googlesource.com/chromium/src/+/b9c3c20ba9a2a3c05b6d0f976e4a2d71c8a74fa6

Patch Set 1 #

Patch Set 2 : removed unit tests that are no longer relevant #

Total comments: 2

Patch Set 3 : removed unnecessary includes #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -221 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 2 3 8 chunks +4 lines, -48 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 1 chunk +0 lines, -143 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_collection_view_controller.mm View 4 chunks +0 lines, -15 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_egtest.mm View 1 2 3 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
pkl (ping after 24h if needed)
PTAL, but I do not plan on landing this until M59 branch has been cut.
3 years, 8 months ago (2017-04-14 06:30:19 UTC) #2
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-14 09:38:00 UTC) #3
Eugene But (OOO till 7-30)
lgtm! https://codereview.chromium.org/2821453003/diff/20001/ios/chrome/browser/tabs/tab.mm File ios/chrome/browser/tabs/tab.mm (left): https://codereview.chromium.org/2821453003/diff/20001/ios/chrome/browser/tabs/tab.mm#oldcode281 ios/chrome/browser/tabs/tab.mm:281: base::scoped_nsobject<NativeAppNavigationController> Are there any includes which now can ...
3 years, 8 months ago (2017-04-14 14:30:51 UTC) #4
pkl (ping after 24h if needed)
https://codereview.chromium.org/2821453003/diff/20001/ios/chrome/browser/tabs/tab.mm File ios/chrome/browser/tabs/tab.mm (left): https://codereview.chromium.org/2821453003/diff/20001/ios/chrome/browser/tabs/tab.mm#oldcode281 ios/chrome/browser/tabs/tab.mm:281: base::scoped_nsobject<NativeAppNavigationController> On 2017/04/14 14:30:51, Eugene But wrote: > Are ...
3 years, 8 months ago (2017-04-14 16:59:23 UTC) #5
rohitrao (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-19 10:53:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821453003/60001
3 years, 7 months ago (2017-05-01 18:12:11 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/b9c3c20ba9a2a3c05b6d0f976e4a2d71c8a74fa6
3 years, 7 months ago (2017-05-01 18:54:53 UTC) #12
pkl (ping after 24h if needed)
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2854183002/ by pkl@chromium.org. ...
3 years, 7 months ago (2017-05-02 17:57:19 UTC) #13
pkl (ping after 24h if needed)
3 years, 7 months ago (2017-05-02 22:39:38 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2854883003/ by pkl@chromium.org.

The reason for reverting is: Nothing's broken, but will reland with an
experimental flag..

Powered by Google App Engine
This is Rietveld 408576698