Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2854863002:
Don't update viewport size from UpdateAfterLayout. (Closed)
DescriptionDon't update viewport size from UpdateAfterLayout.
This was a bug introduced in:
https://codereview.chromium.org/2848043002
BUG=717444
Review-Url: https://codereview.chromium.org/2854863002
Cr-Commit-Position: refs/heads/master@{#468922}
Committed: https://chromium.googlesource.com/chromium/src/+/baa3278ee9b306bb33907408d586fcb7fb3d5dab
Patch Set 1 #Patch Set 2 : Fix ResizeFrameView invocation #Messages
Total messages: 25 (17 generated)
The CQ bit was checked by szager@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by szager@chromium.org to run a CQ dry run
The CQ bit was checked by szager@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Don't update viewport size from UpdateAfterLayout. This was a bug introduced in: https://codereview.chromium.org/2848043002 BUG=717444 ========== to ========== Don't update viewport size from UpdateAfterLayout. This was a bug introduced in: https://codereview.chromium.org/2848043002 BUG=717444 ==========
szager@chromium.org changed reviewers: + cbiesinger@chromium.org, eae@chromium.org
LGTM, thanks Stefan!
The CQ bit was checked by szager@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
szager@chromium.org changed reviewers: + jochen@chromium.org
+jochen@ for Source/web/OWNERS (Hoping to land this before MTV wakes up)
lgtm
The CQ bit was checked by szager@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493801610751150,
"parent_rev": "1a4c6321d2ab77267160bfb0297411e43d0daaab", "commit_rev":
"baa3278ee9b306bb33907408d586fcb7fb3d5dab"}
Message was sent while issue was closed.
Description was changed from ========== Don't update viewport size from UpdateAfterLayout. This was a bug introduced in: https://codereview.chromium.org/2848043002 BUG=717444 ========== to ========== Don't update viewport size from UpdateAfterLayout. This was a bug introduced in: https://codereview.chromium.org/2848043002 BUG=717444 Review-Url: https://codereview.chromium.org/2854863002 Cr-Commit-Position: refs/heads/master@{#468922} Committed: https://chromium.googlesource.com/chromium/src/+/baa3278ee9b306bb33907408d586... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/baa3278ee9b306bb33907408d586... |
