Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2848043002: Refactor WebView resize and update-after-layout methods (Closed)

Created:
3 years, 7 months ago by szager1
Modified:
3 years, 7 months ago
Reviewers:
pdr., skobes
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor WebView resize and update-after-layout methods This changes some method names to make them more accurate, and splits out ResizeAfterLayout from LayoutUpdated. In a subsequent patch, these two methods will be called independently through ChromeClient. BUG=701575 Review-Url: https://codereview.chromium.org/2848043002 Cr-Commit-Position: refs/heads/master@{#468236} Committed: https://chromium.googlesource.com/chromium/src/+/b6c07cb297c05e54ce3865a63b9325fdd8222017

Patch Set 1 #

Patch Set 2 : Tweak names #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 7 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
szager1
pdr@ for web/OWNERS
3 years, 7 months ago (2017-04-28 20:14:47 UTC) #7
skobes
lgtm w/ nit https://codereview.chromium.org/2848043002/diff/20001/third_party/WebKit/Source/web/WebViewImpl.cpp File third_party/WebKit/Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/2848043002/diff/20001/third_party/WebKit/Source/web/WebViewImpl.cpp#newcode3702 third_party/WebKit/Source/web/WebViewImpl.cpp:3702: FrameView* view = webframe->GetFrame()->View(); nit: this ...
3 years, 7 months ago (2017-04-28 20:52:13 UTC) #10
pdr.
On 2017/04/28 at 20:52:13, skobes wrote: > lgtm w/ nit > > https://codereview.chromium.org/2848043002/diff/20001/third_party/WebKit/Source/web/WebViewImpl.cpp > File ...
3 years, 7 months ago (2017-04-28 21:29:21 UTC) #11
szager1
https://codereview.chromium.org/2848043002/diff/20001/third_party/WebKit/Source/web/WebViewImpl.cpp File third_party/WebKit/Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/2848043002/diff/20001/third_party/WebKit/Source/web/WebViewImpl.cpp#newcode3702 third_party/WebKit/Source/web/WebViewImpl.cpp:3702: FrameView* view = webframe->GetFrame()->View(); On 2017/04/28 20:52:13, skobes (OOO ...
3 years, 7 months ago (2017-04-29 09:11:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848043002/40001
3 years, 7 months ago (2017-04-29 09:11:13 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 11:04:58 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b6c07cb297c05e54ce3865a63b93...

Powered by Google App Engine
This is Rietveld 408576698