Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2854823006: headless: Remove deprecated DevTools domain bindings (Closed)

Created:
3 years, 7 months ago by Sami
Modified:
3 years, 7 months ago
Reviewers:
altimin
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Remove deprecated DevTools domain bindings Instead of //headless/public/domains, headers under //headless/public/devtools should now be used. BUG=718242 Review-Url: https://codereview.chromium.org/2854823006 Cr-Commit-Position: refs/heads/master@{#469312} Committed: https://chromium.googlesource.com/chromium/src/+/6bac5f64f82e95a97fb1cba2fbc9bd8ed8bc8983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -75 lines) Patch
M headless/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M headless/lib/browser/devtools_api/client_api_generator.py View 4 chunks +0 lines, -35 lines 0 comments Download
M headless/lib/browser/devtools_api/client_api_generator_unittest.py View 1 chunk +1 line, -2 lines 0 comments Download
D headless/lib/browser/devtools_api/deprecated_domain_h.template View 1 chunk +0 lines, -7 lines 0 comments Download
D headless/lib/browser/devtools_api/deprecated_type_conversions_h.template View 1 chunk +0 lines, -14 lines 0 comments Download
D headless/lib/browser/devtools_api/deprecated_types_h.template View 1 chunk +0 lines, -14 lines 0 comments Download
M headless/lib/headless_browser_context_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Sami
3 years, 7 months ago (2017-05-04 10:43:56 UTC) #5
altimin
lgtm, thanks!
3 years, 7 months ago (2017-05-04 10:46:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854823006/1
3 years, 7 months ago (2017-05-04 10:55:34 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 11:40:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6bac5f64f82e95a97fb1cba2fbc9...

Powered by Google App Engine
This is Rietveld 408576698