Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: headless/lib/browser/devtools_api/client_api_generator.py

Issue 2854823006: headless: Remove deprecated DevTools domain bindings (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/BUILD.gn ('k') | headless/lib/browser/devtools_api/client_api_generator_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/devtools_api/client_api_generator.py
diff --git a/headless/lib/browser/devtools_api/client_api_generator.py b/headless/lib/browser/devtools_api/client_api_generator.py
index fd011e10ffd65fffb653fb6c1c3aff3a1bed25dd..96758961f9ec3b5cc3a2ed493cdf8b2ff7bdc6ed 100644
--- a/headless/lib/browser/devtools_api/client_api_generator.py
+++ b/headless/lib/browser/devtools_api/client_api_generator.py
@@ -444,25 +444,6 @@ def EnsureCommandsHaveParametersAndReturnTypes(json_api):
event['parameters'] = []
-def Generate(jinja_env, output_dirname, json_api,
- class_name, file_types, file_name=None):
- if file_name is None:
- file_name = class_name
- EnsureDirectoryExists(output_dirname)
- template_context = {
- 'api': json_api,
- 'join_arrays': JoinArrays,
- 'resolve_type': ResolveType,
- 'type_definition': TypeDefinition,
- }
- for file_type in file_types:
- template = jinja_env.get_template('/%s_%s.template' % (
- class_name, file_type))
- output_file = '%s/%s.%s' % (output_dirname, file_name, file_type)
- with open(output_file, 'w') as f:
- f.write(template.render(template_context))
-
-
def GeneratePerDomain(jinja_env, output_dirname, json_api, class_name,
file_types, domain_name_to_file_name_func):
EnsureDirectoryExists(output_dirname)
@@ -488,12 +469,6 @@ def GenerateDomains(jinja_env, output_dirname, json_api):
'domain', ['cc', 'h'],
lambda domain_name: domain_name)
- # TODO(altimin): Remove this in 2017.
- # Generate DOMAIN.h in the old directory for backwards compatibility.
- GeneratePerDomain(
- jinja_env, os.path.join(output_dirname, 'domains'), json_api,
- 'deprecated_domain', ['h'], lambda domain_name: domain_name)
-
def GenerateTypes(jinja_env, output_dirname, json_api):
# Generate forward declarations for types.
@@ -507,11 +482,6 @@ def GenerateTypes(jinja_env, output_dirname, json_api):
json_api, 'domain_types', ['h', 'cc'],
lambda domain_name: 'types_%s' % (domain_name, ))
- # TODO(altimin): Remove this in 2017.
- # Generate types.h for backwards compatibility.
- Generate(jinja_env, os.path.join(output_dirname, 'domains'), json_api,
- 'deprecated_types', ['h'], 'types')
-
def GenerateTypeConversions(jinja_env, output_dirname, json_api):
# Generate type conversions on per-domain basis.
@@ -520,11 +490,6 @@ def GenerateTypeConversions(jinja_env, output_dirname, json_api):
json_api, 'domain_type_conversions', ['h'],
lambda domain_name: 'type_conversions_%s' % (domain_name, ))
- # TODO(altimin): Remove this in 2017.
- # Generate type_conversions.h for backwards compatibility.
- Generate(jinja_env, os.path.join(output_dirname, 'domains'), json_api,
- 'deprecated_type_conversions', ['h'], 'type_conversions')
-
if __name__ == '__main__':
json_api, output_dirname = ParseArguments(sys.argv[1:])
« no previous file with comments | « headless/BUILD.gn ('k') | headless/lib/browser/devtools_api/client_api_generator_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698