Remove the last references from production code to WebViewImpl.

Remove the last references from production code to WebViewImpl.

This CL is a continuation of removing dependencies in the code on WebViewImpl, by
introducing the pure virtual class WebViewBase and moving methods from WebViewImpl
to virtual methods in WebViewBase and overriding them in WebViewImpl.

It also removes a few of the cast to WebViewImpl, and replaces them with a direct
static cast to WebViewBase.

BUG=712963
Review-Url: https://codereview.chromium.org/2854783003
Cr-Commit-Position: refs/heads/master@{#468580}
Committed: https://chromium.googlesource.com/chromium/src/+/ceb538b1bb7f9067f80535bd00f49b81344b8823

[slangley, 2017-05-02 06:16:35]

Description was changed from

==========
Remove the last references from production code to WebViewImpl.

BUG=
==========

to

==========
Remove the last references from production code to WebViewImpl.

This CL is a continuation of removing dependencies in the code on WebViewImpl,
by
introducing the pure virtual class WebViewBase and moving methods from
WebViewImpl
to virtual methods in WebViewBase and overriding them in WebViewImpl.

It also removes a few of the cast to WebViewImpl, and replaces them with a
direct
static cast to WebViewBase.

BUG=712963
==========

[slangley, 2017-05-02 06:25:33]

slangley@chromium.org changed reviewers:
+ haraken@chromium.org

[slangley, 2017-05-02 06:25:34]

https://codereview.chromium.org/2854783003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp (right):

https://codereview.chromium.org/2854783003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp:96: return new
WebViewFrameWidget(*client, static_cast<WebViewBase&>(*web_view),
The only concrete type inherits WebViewBase, so a straight cast here should be
OK.

[haraken, 2017-05-02 06:27:07]

LGTM

[slangley, 2017-05-02 06:28:18]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-02 06:28:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 07:55:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493706498541840,
"parent_rev": "317eb67a43957db557f51f360dfeb3a40ffdd690", "commit_rev":
"ceb538b1bb7f9067f80535bd00f49b81344b8823"}

[commit-bot: I haz the power, 2017-05-02 07:55:39]

Description was changed from

==========
Remove the last references from production code to WebViewImpl.

This CL is a continuation of removing dependencies in the code on WebViewImpl,
by
introducing the pure virtual class WebViewBase and moving methods from
WebViewImpl
to virtual methods in WebViewBase and overriding them in WebViewImpl.

It also removes a few of the cast to WebViewImpl, and replaces them with a
direct
static cast to WebViewBase.

BUG=712963
==========

to

==========
Remove the last references from production code to WebViewImpl.

This CL is a continuation of removing dependencies in the code on WebViewImpl,
by
introducing the pure virtual class WebViewBase and moving methods from
WebViewImpl
to virtual methods in WebViewBase and overriding them in WebViewImpl.

It also removes a few of the cast to WebViewImpl, and replaces them with a
direct
static cast to WebViewBase.

BUG=712963

Review-Url: https://codereview.chromium.org/2854783003
Cr-Commit-Position: refs/heads/master@{#468580}
Committed:
https://chromium.googlesource.com/chromium/src/+/ceb538b1bb7f9067f80535bd00f4...
==========

[commit-bot: I haz the power, 2017-05-02 07:55:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ceb538b1bb7f9067f80535bd00f4...