Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2854783003: Remove the last references from production code to WebViewImpl. (Closed)
Patch Set: Remove TODO(). Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index b60e37ae23384a45b01125d9fffad117a3bac29c..b694d0bda89e119db3ebbc2117e4f39297d9ae19 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -384,10 +384,12 @@ Page* ChromeClientImpl::CreateWindow(LocalFrame* frame,
DCHECK(frame->GetDocument());
Fullscreen::FullyExitFullscreen(*frame->GetDocument());
- WebViewImpl* new_view = ToWebViewImpl(web_view_->Client()->CreateView(
- WebLocalFrameImpl::FromFrame(frame),
- WrappedResourceRequest(r.GetResourceRequest()), features, r.FrameName(),
- policy, r.GetShouldSetOpener() == kNeverSetOpener || features.noopener));
+ WebViewBase* new_view =
+ static_cast<WebViewBase*>(web_view_->Client()->CreateView(
+ WebLocalFrameImpl::FromFrame(frame),
+ WrappedResourceRequest(r.GetResourceRequest()), features,
+ r.FrameName(), policy,
+ r.GetShouldSetOpener() == kNeverSetOpener || features.noopener));
if (!new_view)
return nullptr;
return new_view->GetPage();
« no previous file with comments | « third_party/WebKit/Source/core/exported/WebViewBase.h ('k') | third_party/WebKit/Source/web/ValidationMessageClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698