Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2854773003: Password manager should autofill a dynamic form added and processed before the page was loaded. (Closed)

Created:
3 years, 7 months ago by vasilii
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Password manager should autofill a dynamic form added and processed before the page was loaded. Currently AutofillAgent::DidAssociateFormControlsDynamically ignores the notification if the frame isn't loaded. That makes no sense because the page may never be loaded due to some slow resource. Even if it will, password autofill shouldn't wait for the page load event. It's needed primarily for the successful submission detection. BUG=713645 Review-Url: https://codereview.chromium.org/2849653003 Cr-Commit-Position: refs/heads/master@{#468136} (cherry picked from commit 31ba8c6c5838fd6e65f3e341cfb5af0736186dc3) Review-Url: https://codereview.chromium.org/2854773003 . Cr-Commit-Position: refs/branch-heads/3071@{#342} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/8da0ab3664c77f527e2cc845c5349bf37f79f959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -10 lines) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/test/data/password/infinite_password_form.html View 1 chunk +26 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vasilii
3 years, 7 months ago (2017-05-02 10:40:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8da0ab3664c77f527e2cc845c5349bf37f79f959.

Powered by Google App Engine
This is Rietveld 408576698