Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 2854773003: Password manager should autofill a dynamic form added and processed before the page was loaded. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/password/infinite_password_form.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index 625f9e1ef0cca82d5929a679173fac9d6c155919..ef165ba059eb4bc9fdf3ff81084e142e4a986495 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -737,16 +737,12 @@ bool AutofillAgent::IsUserGesture() const {
}
void AutofillAgent::DidAssociateFormControlsDynamically() {
- blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
-
- // Frame is only processed if it has finished loading, otherwise you can end
- // up with a partially parsed form.
- if (frame && !frame->IsLoading()) {
- ProcessForms();
- password_autofill_agent_->OnDynamicFormsSeen();
- if (password_generation_agent_)
- password_generation_agent_->OnDynamicFormsSeen();
- }
+ // If the control flow is here than the document was at least loaded. The
+ // whole page doesn't have to be loaded.
+ ProcessForms();
+ password_autofill_agent_->OnDynamicFormsSeen();
+ if (password_generation_agent_)
+ password_generation_agent_->OnDynamicFormsSeen();
}
void AutofillAgent::DidCompleteFocusChangeInFrame() {
« no previous file with comments | « chrome/test/data/password/infinite_password_form.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698